New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestClientTransport inherits from wrong base #90

Open

devkral opened this issue Oct 1, 2024 · 1 comment

Contributor

devkral commented Oct 1, 2024

TestClientTransport is supposed to handle ASGI but inherits from httpx.BaseTransport which is for WSGI and handles with deprecation warnings ASGI.

It should inherit of httpx.AsyncBaseTransport and implement it.

Contributor

tarsil commented Oct 1, 2024

Yes that is correct. For the async client we adopt something else. In fact you are correct. We should implement the AsyncTestClient directly.

We should also deprecate python 3.8 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment