Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: external contribution CI will fail #124

Open
allgreed opened this issue Jul 28, 2022 · 1 comment
Open

Regression: external contribution CI will fail #124

allgreed opened this issue Jul 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@allgreed
Copy link
Contributor

allgreed commented Jul 28, 2022

So #109 broke something solved by #54
I've confirmed with @airborn that it only affects CI runs on a PRs from a fork.

Workaround:
Someone with admin powers (likely me) will just verify the contributions manually and override the check requirement should any contributions happen until a fix is issued

Non-starters:
Previous solution is unacceptable as it doubles quadruples the CI execution time.

@allgreed allgreed added the bug Something isn't working label Jul 28, 2022
@airborn
Copy link
Member

airborn commented Aug 4, 2022

A possible solution could be to use on: pull_request_target instead of on: pull_request although this has some limitations: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants