Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make library not single threaded and more DI-able #1

Open
3 tasks
eByte23 opened this issue Mar 10, 2017 · 0 comments
Open
3 tasks

[BUG] Make library not single threaded and more DI-able #1

eByte23 opened this issue Mar 10, 2017 · 0 comments

Comments

@eByte23
Copy link
Owner

eByte23 commented Mar 10, 2017

Essentially this is currently single threaded and really can't use di because of all the inline ctor deps

Actions:

  • Find all constructors where classes inherit interfaces that are created dynamically make the initialised with method on interface not ctor.

  • Change where all documents are signed to a signing provider so it all uses the configuration of what hash type etc..

  • Classes like Saml20Metadata, Saml20AuthNRequest, etc.. remove the constructors as this is a stupid way of doing shit and its all over the shop

@eByte23 eByte23 added this to the V0.1.0 release milestone Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant