Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py does not properly pull in requirements because it imports things that it shouldn't #1

Open
fiendish opened this issue Jul 12, 2021 · 0 comments · May be fixed by #2
Open

setup.py does not properly pull in requirements because it imports things that it shouldn't #1

fiendish opened this issue Jul 12, 2021 · 0 comments · May be fixed by #2

Comments

@fiendish
Copy link

pip install git+https://github.com/eDIMESLab/MedicalImageAnonymizer or pip install . in a clone should install necessary requirements for you if setup.py is well constructed, but it doesn't.

The problem is that your setup.py in

from MedicalImageAnonymizer.build import get_requires
invokes MedicalImageAnonymizer.__init__ and
from .DICOM_anonymizer import DICOMAnonymize
in turn imports DICOM_anonymizer.py which imports pydicom, which is not installed yet unless one manually installs the requirements in advance, which again should not be needed.

Please either move build.py out of the MedicalImageAnonymizer subdirectory or just put those two contained functions get_requires and read_description directly into setup.py which is the only place they are used.

@fiendish fiendish linked a pull request Jul 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant