New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVS anonymize outfile argument ignored if infolog is False #4

Open

fiendish opened this issue Jul 12, 2021 · 0 comments

fiendish commented Jul 12, 2021 •

edited

Loading

Outfile assignment only happens if infolog is True, but they should/could be entirely independent of each other.

MedicalImageAnonymizer/MedicalImageAnonymizer/SVS_anonymizer.py

Lines 287 to 300 in a2b03ee

 if infolog: 

 root, ext = os.path.splitext(self._filename) 

 if outfile is None: 

 outfile = root + '_anonym.svs' 

 shutil.copyfile(self._filename, outfile) 

 filename = outfile 

 infos = dict() 

 else: 

 filename = self._filename

The above snippet is from the SVS anonymizer, but the same pattern appears to be repeated in the others as well.

I think it would make more sense for the outfile assignment to work regardless of whether you want the additional info file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment