Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light: Replace #E50000 to #CC0000 #13

Open
svipas opened this issue Nov 12, 2023 · 0 comments
Open

Light: Replace #E50000 to #CC0000 #13

svipas opened this issue Nov 12, 2023 · 0 comments
Labels
feature New feature or request triage Needs to be looked at

Comments

@svipas
Copy link

svipas commented Nov 12, 2023

My suggestion would be to replace #E50000 which is too bright and fails contrast checker to #CC0000. I see that this theme uses default colors except it modifies workbench, but still I would love to see this modification since it improves readability. WDYT?

  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": [
          "entity.other.attribute-name",
          "support.type.vendored.property-name",
          "support.type.property-name",
          "variable.css",
          "variable.scss",
          "variable.other.less",
          "source.coffee.embedded"
        ],
        "settings": {
          "foreground": "#cc0000"
        }
      }
    ]
  },
@svipas svipas added feature New feature or request triage Needs to be looked at labels Nov 12, 2023
@svipas svipas changed the title Replace #E50000 to #CC0000 Light: Replace #E50000 to #CC0000 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request triage Needs to be looked at
Projects
None yet
Development

No branches or pull requests

1 participant