From 9c96239edead9ffa4a6f8c289a408c190d1e82d2 Mon Sep 17 00:00:00 2001 From: Pierre Date: Fri, 12 Apr 2024 17:47:10 +0200 Subject: [PATCH 1/2] Fix for coverage and lint workflow jobs - src/benchmarkstt/core.py : E741 ambiguous variable name 'l' - setup.py : jsonrpcserver max version 5 - error Protocol import from typing for python >= 3.8 --- setup.py | 2 +- src/benchmarkstt/metrics/core.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index d7765b2e..29e282aa 100644 --- a/setup.py +++ b/setup.py @@ -60,7 +60,7 @@ def filter_requirements(line): install_requires=[ 'MarkupSafe>=1.0', 'Flask>=1.0.2', - 'jsonrpcserver>=4.0.1', + 'jsonrpcserver>=4.0.1,<5', 'gunicorn>=19.9.0', 'docutils>=0.14', 'editdistance>=0.5.3', diff --git a/src/benchmarkstt/metrics/core.py b/src/benchmarkstt/metrics/core.py index 9f564b31..cba33860 100644 --- a/src/benchmarkstt/metrics/core.py +++ b/src/benchmarkstt/metrics/core.py @@ -328,7 +328,7 @@ def __generate_list_entity(self, list_parsed): index_entities.extend(index_entity) # sort on the position of the first part of the entity - index_entities.sort(key=lambda l: l[0]) + index_entities.sort(key=lambda elem: elem[0]) # copy-past the entity found in the list for k_list in index_entities: From a66e6c5474ca6c4290eb48c5e36a234b25cad571 Mon Sep 17 00:00:00 2001 From: Pierre Date: Mon, 15 Apr 2024 14:53:31 +0200 Subject: [PATCH 2/2] github workflows exclude os/python version combinations --- .github/workflows/pythonpackage.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml index 624a5e8a..bddbd903 100644 --- a/.github/workflows/pythonpackage.yml +++ b/.github/workflows/pythonpackage.yml @@ -10,6 +10,19 @@ jobs: matrix: os: [ubuntu-latest, macos-latest, windows-latest] python-version: [3.5, 3.6, 3.7, 3.8, 3.9] + exclude: + - os: macos-latest + python-version: 3.5 + - os: windows-latest + python-version: 3.5 + - os: ubuntu-latest + python-version: 3.5 + - os: macos-latest + python-version: 3.6 + - os: windows-latest + python-version: 3.6 + - os: ubuntu-latest + python-version: 3.6 runs-on: ${{matrix.os}}