Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification Needed on FirstDayOfMonth Key in LISFLOOD Settings XML #157

Open
Nooshdokht-Bayatafshary opened this issue May 23, 2024 · 1 comment

Comments

@Nooshdokht-Bayatafshary

Dear Developers,

I am currently working on setting options in the LISFLOOD settings XML file for calibrating my region. According to the LISFLOOD Settings and Options Annex, it appears that the firstdayofmonth.txt table is no longer necessary. However, I still see the FirstDayOfMonth key present in all XML templates.
Could you please clarify whether the FirstDayOfMonth key is still required? Is it safe to remove this key from my settings file?
Thank you for your assistance.

Best regards,
Nooshdokht

@StefaniaGrimaldi
Copy link
Contributor

Dear @Nooshdokht-Bayatafshary,

thank you for your enquiry.

You are correct: FirstDayOfMonth key is no longer needed (this is a legacy of older versions. Dynamic water demand maps are now provided in netcdf stack format).
We strive to keep documentation and reference .xml up-to-date but errors/legacies are possible.
We will remove the key from the lisfloodSettings_reference.xml in the next release.

Please do not hesitate to raise other issues,
on behalf of the developers team,
Stefania

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants