Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions #162

Open
corentincarton opened this issue Jul 11, 2024 · 2 comments · Fixed by #164
Open

GitHub Actions #162

corentincarton opened this issue Jul 11, 2024 · 2 comments · Fixed by #164

Comments

@corentincarton
Copy link
Collaborator

@doc78, I see that the GitHub actions are running for all the branches and all the commits, which is a bit overkill. Shouldn't we run them just for the PR to develop and master? Here's an example on how it could be done:
https://github.com/ecmwf/pyflow/blob/develop/.github/workflows/ci.yml

@doc78
Copy link
Collaborator

doc78 commented Jul 12, 2024

@corentincarton I actually use it to check the unit tests every time I push something new on any branch, instead of waiting for them to be merged in develop. However it is ok for me to limit the actions just on PR if it is annoying with many notifications.
Feel free to modify the ci.yml file and push it as you like.

@corentincarton
Copy link
Collaborator Author

@doc78 , thanks. I'll work on a PR with a new version of the ci that is activated only when we are ready to merge to develop. I think running it all the time on all the branches is a waste of resources and is indeed a bit annoying as we get ci failure notifications all the time.

@corentincarton corentincarton linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants