repository size

[blazk]

Hi, I've just tried to clone Lisvap repository and the size is 2.3 GB. it's a bit unmanageable. Could it be possibly reduced?

[domeniconappo]

@blazk
I struggled to make it "uploadable" on github so I've already reduced at minimum the size of input files for tests. That's the source of the problem. Let us discuss to find an alternative. At the moment, we only have that kind of black box tests and we need a minimum "full dataset". Since tests are for developers, they must be included in the repository.
Same problem on lisflood-code repo but here we have a GLOFAS test so here it's more problematic.

What do you need to do with it? Which kind of managing problems do you have in particular?
Are you going to clone the repo from scratch so often?
I mean: the typical use case is to clone it once so it's not a real problem.

[blazk]

Thanks for looking into it!

It will be cloned often, we have automated deployment procedures where our systems are assembled from many packages and these packages are cloned from git repos.

Do developers actually need to use realistic maps to run tests? If these tests only check if results stay the same after the code change, then maybe you could use small e.g. 3x2 pixel maps (attached)
3x2_map.zip

[domeniconappo]

Hi,
ideally, we shouldn't have those real case tests but rather a battery of unit tests and some full tests on smaller maps. For the moment, we need it as we feel safer in that way :) Code is far away to be well designed to easily write unit tests.
Anyway, lisvap can be used as a pypi package. The package does not include tests and it's very quick to install. Is it an option to install it with the pip tool of your Python env?

pip install lisflood-lisvap

[domeniconappo]

@blazk
Hi Blazej,
any opinion on this?

[blazk]

I suppose we could use "pip install lisflood-lisvap". How much up-to-date do you keep the pip package?

When we install from git, we have a custom installation procedure. Part of this procedure is to configure the package, e.g. in case of LISVAP we set the "PathBaseMapsIn" variable in the XML settings template file - this variable does not change in our case so it can be set to a fixed value during package's installation. It may sound like a small detail but actually it's important from architecture point of view (encapsulation!) - it means that the client code that calls LISVAP doesn't need to know how to set "PathBaseMapsIn", which means the client code can be simpler.

But anyway, sorry for digression, I think we can do it, eg. install LISVAP from pip and then have an auxiliary package with the XML settings template only.

[domeniconappo]

Pip package is in sync with git version, as soon as there is a new tag/release.

Maybe we can use pip with --install-option arg, to pass extra arguments to the setup.py script. So you can pass the path and I can produce the XML template for you during installation. I will look into it in a few days.

https://pip.pypa.io/en/stable/reference/pip_install/#cmdoption-install-option

[blazk]

sounds good, thanks!