Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Relationship Type in *.rels #202

Closed
FrankSchnicke opened this issue Nov 16, 2023 · 3 comments · Fixed by #205
Closed

Wrong Relationship Type in *.rels #202

FrankSchnicke opened this issue Nov 16, 2023 · 3 comments · Fixed by #205

Comments

@FrankSchnicke
Copy link
Contributor

See https://github.com/admin-shell-io/temp-aasx-package-explorer/issues/124.

I think this should be fixed backwards compatible to ensure we're not losing compatibility with old files created by a milestone release of AAS4J. What do you think @mjacoby, @twebermartins?

@FrankSchnicke FrankSchnicke changed the title Wrong Relationship Type in aasx-origin.rels Wrong Relationship Type in *.rels Nov 16, 2023
@mjacoby
Copy link
Contributor

mjacoby commented Nov 17, 2023

I'm not sure what the best solution would be in this case...on the one hand we are talking about milestone releases which I guess would in theory allow adding breaking changes. However, I agree that this will most likely cause problems and disappointment from the users that they no longer can load files create by the previous version.

Therefore, I see two potential approaches (if technically possible)

  1. Keep backwards compatibility by supporting both http://www.admin-shell.io/aasx/relationships and http://admin-shell.io/aasx/relationships. We should add a warning message when loading a file using the "old" URL that the file is not compliant to the standard and will no longer be supported with the next release. Also we should always save files using the correct URL.
  2. Remove support for "old" URL. In this case we should a a big fat note in the release notes stating the problem. We should also provide some simple command line tool to fix existing AASX files and should link that tool in the release notes.

I am fine with any of these two approaches.

@FrankSchnicke
Copy link
Contributor Author

I think approach 1) would be feasible with little effort. I can take a look at implementing this next week.

@twebermartins
Copy link
Contributor

I would also keep backwards compatibility for now. The idea of warning users is a good idea. And I would always automatically convert to the format as described in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants