From 1545e47c6867ae2746397188037da2f1a570d8ad Mon Sep 17 00:00:00 2001 From: zrgt Date: Mon, 16 Oct 2023 22:51:22 +0200 Subject: [PATCH] Set `id_short` of `Identifiables` to optional This commit extends https://github.com/eclipse-basyx/basyx-python-sdk/commit/bffb075ce03f7668b2a341544b63e27265ef715d. --- basyx/aas/model/aas.py | 2 +- basyx/aas/model/concept.py | 2 +- basyx/aas/model/submodel.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/basyx/aas/model/aas.py b/basyx/aas/model/aas.py index b53a423c0..c99efc594 100644 --- a/basyx/aas/model/aas.py +++ b/basyx/aas/model/aas.py @@ -112,7 +112,7 @@ class AssetAdministrationShell(base.Identifiable, base.UniqueIdShortNamespace, b def __init__(self, asset_information: AssetInformation, id_: base.Identifier, - id_short: base.NameType = "NotSet", + id_short: Optional[base.NameType] = None, display_name: Optional[base.MultiLanguageNameType] = None, category: Optional[base.NameType] = None, description: Optional[base.MultiLanguageTextType] = None, diff --git a/basyx/aas/model/concept.py b/basyx/aas/model/concept.py index 07472b9f9..89a8e9b83 100644 --- a/basyx/aas/model/concept.py +++ b/basyx/aas/model/concept.py @@ -60,7 +60,7 @@ class ConceptDescription(base.Identifiable, base.HasDataSpecification): def __init__(self, id_: base.Identifier, is_case_of: Optional[Set[base.Reference]] = None, - id_short: base.NameType = "NotSet", + id_short: Optional[base.NameType] = None, display_name: Optional[base.MultiLanguageNameType] = None, category: Optional[base.NameType] = None, description: Optional[base.MultiLanguageTextType] = None, diff --git a/basyx/aas/model/submodel.py b/basyx/aas/model/submodel.py index d14e87178..1977d774c 100644 --- a/basyx/aas/model/submodel.py +++ b/basyx/aas/model/submodel.py @@ -122,7 +122,7 @@ class Submodel(base.Identifiable, base.HasSemantics, base.HasKind, base.Qualifia def __init__(self, id_: base.Identifier, submodel_element: Iterable[SubmodelElement] = (), - id_short: base.NameType = "NotSet", + id_short: Optional[base.NameType] = None, display_name: Optional[base.MultiLanguageNameType] = None, category: Optional[base.NameType] = None, description: Optional[base.MultiLanguageTextType] = None,