Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove agemo specifics from config_utils #68

Merged
merged 35 commits into from
Jan 18, 2024
Merged

Conversation

devkelley
Copy link
Contributor

@devkelley devkelley commented Jan 17, 2024

Motivation and Context

Makes config work easier to integrate into other projects.

Description

Removes agemo specific implementation from config_utils file.
Splits up the gathering of configuration into:

  • default config
  • config from file
  • commandline config

This separation should allow for the util code to be easily placed in a common repo in the future. It should also allow for more flexibility.

@devkelley devkelley changed the title Devkelley/config util remove agemo specifics from config_utils Jan 17, 2024
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@ladatz ladatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

common/src/config_utils.rs Outdated Show resolved Hide resolved
@devkelley devkelley merged commit 396d49a into main Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants