Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Node.js v18 #901

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Move to Node.js v18 #901

merged 4 commits into from
Aug 30, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Aug 18, 2023

What does this PR do?

  • set Node.js version >= 18;
  • upgrade project dependencies to latest versions;
  • fix unit-tests;
  • fix webpack configs;
  • update GH workflow files;

What issues does this PR fix or reference?

resolves eclipse-che/che#22227

@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Aug 18, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-901

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #901 (fa57639) into main (8f95e78) will decrease coverage by 0.04%.
The diff coverage is 85.49%.

❗ Current head fa57639 differs from pull request most recent head 25940ad. Consider uploading reports for the commit 25940ad to get more accurate results

@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   81.73%   81.69%   -0.04%     
==========================================
  Files         347      346       -1     
  Lines       36032    36062      +30     
  Branches     2263     2285      +22     
==========================================
+ Hits        29450    29461      +11     
- Misses       6558     6577      +19     
  Partials       24       24              
Flag Coverage Δ
unittests 81.69% <85.49%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard-backend/src/server.ts 0.00% <0.00%> (ø)
...rd-frontend/src/services/workspace-client/index.ts 91.30% <ø> (-0.37%) ⬇️
...ontend/src/store/InfrastructureNamespaces/index.ts 0.00% <0.00%> (ø)
...rd-backend/src/routes/api/devworkspaceResources.ts 64.28% <32.14%> (+1.32%) ⬆️
.../dashboard-backend/src/routes/api/devfileSchema.ts 71.15% <37.50%> (+1.15%) ⬆️
.../dashboard-backend/src/routes/workspaceRedirect.ts 80.64% <40.00%> (+1.33%) ⬆️
...es/GetStarted/GetStartedTab/SamplesListGallery.tsx 71.92% <50.00%> (-0.39%) ⬇️
...-frontend/src/services/workspace-client/helpers.ts 89.28% <66.66%> (-0.54%) ⬇️
...es/dashboard-backend/src/routes/api/podmanLogin.ts 87.50% <73.91%> (+0.54%) ⬆️
...rvices/dashboard-backend-client/yamlResolverApi.ts 50.00% <75.00%> (+1.28%) ⬆️
... and 24 more

... and 2 files with indirect coverage changes

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-901

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-901

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-901

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-901

@akurinnoy
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-901

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 061c564 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akurinnoy akurinnoy merged commit 75d9743 into main Aug 30, 2023
11 checks passed
@akurinnoy akurinnoy deleted the bump-nodejs branch August 30, 2023 12:40
@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/308: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/4073: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/308: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4271 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1793: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: sync-to-downstream_3.x/4272: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4126 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.x/1896: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4272 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1289: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/4073: SUCCESS

Detected new images: rebuild operator-bundle
* code
* configbump
* dashboard
* devfileregistry
* devspaces-operator
* idea
* imagepuller
* machineexec
* pluginregistry
* server
* traefik
* udi; /DS_CI/operator-bundle_3.x/1896 triggered

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1793: SUCCESS

3.9
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.9-221
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-566258-533291-s390x
  + quay.io/devspaces/iib:3.9-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.9-v4.13-566255-533286-s390x
  + quay.io/devspaces/iib:3.9-v4.12-566369-533281-s390x
  + quay.io/devspaces/iib:3.9-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.9-v4.11-566355-533277-s390x
  + quay.io/devspaces/iib:3.9-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.9-v4.10-566349-533276-s390x
  + quay.io/devspaces/iib:3.9-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-566258-533291-ppc64le
  + quay.io/devspaces/iib:3.9-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-566377-533286-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-566369-533281-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-566355-533277-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.9-v4.10-566349-533276-ppc64le
  + quay.io/devspaces/iib:3.9-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-566258-533291-x86_64
  + quay.io/devspaces/iib:3.9-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-566377-533286-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-566369-533281-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-566355-533277-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.9-v4.10-566349-533276-x86_64
  + quay.io/devspaces/iib:3.9-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[che-dashboard] Bump NodeJS to v18
5 participants