-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to devfile metadata via ConfigMap #912
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-912 |
packages/dashboard-backend/src/devworkspaceClient/__tests__/index.spec.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/routes/api/gettingStartedSample.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/routes/api/gettingStartedSample.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/devworkspaceClient/services/gettingStartedSamplesApi.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/devworkspaceClient/services/gettingStartedSamplesApi.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-backend/src/devworkspaceClient/services/gettingStartedSamplesApi.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.10 :: dashboard_3.x/317: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.x/316: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4357: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4356: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4188: dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4189: dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN |
Build 3.10 :: dashboard_3.x/318: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4388: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3115: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4199: dashboard : 3.x :: Build 55187175 : quay.io/devspaces/dashboard-rhel8:3.10-3 |
What does this PR do?
feat: Allow to devfile metadata via ConfigMap
What issues does this PR fix or reference?
eclipse-che/che#22429
Is it tested? How?
Open Dashboard and start a workspace from a new sample.
Release Notes
N/A
Docs PR
eclipse-che/che-docs#2646