Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to devfile metadata via ConfigMap #912

Merged
merged 5 commits into from
Sep 6, 2023
Merged

feat: Allow to devfile metadata via ConfigMap #912

merged 5 commits into from
Sep 6, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 4, 2023

What does this PR do?

feat: Allow to devfile metadata via ConfigMap

What issues does this PR fix or reference?

eclipse-che/che#22429

Is it tested? How?

chectl server:deploy -p minikube

kubectl patch checluster/eclipse-che --patch '{"spec": {"components": {"dashboard": {"deployment": {"containers": [{"image": "quay.io/abazko/che-dashboard:22429"}]}}}}}' --type=merge -n eclipse-che

kubectl apply -f - <<EOF                                                                                                                   
apiVersion: v1    
kind: ConfigMap
metadata:
  name: getting-started-sample
  namespace: eclipse-che
  labels:
    app.kubernetes.io/part-of: che.eclipse.org
    app.kubernetes.io/component: getting-started-samples
data:
  my-samples: |-
    [
      {
        "displayName": "Eclipse Che Dashboard",
        "description": "Specifies development environment needed to develop the Eclipse Che Dashboard.",
        "tags": ["Eclipse Che", "Dashboard"],
        "url": "https://github.com/che-incubator/quarkus-api-example/"
      }
    ]
EOF

Open Dashboard and start a workspace from a new sample.

Release Notes

N/A

Docs PR

eclipse-che/che-docs#2646

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-912

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-912

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Знімок екрана 2023-09-05 о 18 22 27
LGTM

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-912

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 30f814b into main Sep 6, 2023
9 checks passed
@tolusha tolusha deleted the 22429 branch September 6, 2023 13:21
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/317: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/316: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4188: FAILURE

dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4189: FAILURE

dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/318: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants