-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add console logging che-server exception messages #913
Conversation
Signed-off-by: Igor <ivinokur@redhat.com>
console.error(e.message); | ||
} | ||
if (e.response && e.response.data && e.response.data.trace) { | ||
console.error(e.response.data.trace.join('\n')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.error(e.response.data.trace.join('\n')); | |
console.error(common.helpers.errors.getMessage(e)); |
@vinokurig Could you move the next code e.response.data.trace.join('\n')
into 'getMessage' function (https://github.com/eclipse-che/che-dashboard/blob/main/packages/common/src/helpers/errors.ts#L63-L65) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a stack trace list and it is provision error specific, so it makes no sense to put it into the common error class.
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-913 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-913 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-913 |
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Build 3.10 :: dashboard_3.x/323: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.x/322: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4414: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4415: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3124: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3125: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4220: dashboard : 3.x :: Build 55208052 : quay.io/devspaces/dashboard-rhel8:3.10-7 |
Build 3.10 :: dashboard_3.x/323: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4415 triggered |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4219: dashboard : 3.x :: Build 55208051 : quay.io/devspaces/dashboard-rhel8:3.10-8 |
Build 3.10 :: update-digests_3.x/4151: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.x/322: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4414 triggered |
Build 3.10 :: operator-bundle_3.x/1968: Console, Changes, Git Data |
Build 3.10 :: update-digests_3.x/4152: Console, Changes, Git Data |
Build 3.10 :: operator-bundle_3.x/1969: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.x/324: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4440: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3133: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4244: dashboard : 3.x :: Build 55222930 : quay.io/devspaces/dashboard-rhel8:3.10-9 |
Build 3.10 :: dashboard_3.x/324: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4440 triggered |
Build 3.10 :: update-digests_3.x/4170: Console, Changes, Git Data |
Build 3.10 :: operator-bundle_3.x/1987: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4446: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4251: devspaces-operator-bundle : 3.x :: Failed in 55223149 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Add console error logging on
che-server
failure:What issues does this PR fix or reference?
fixes eclipse-che/che#22423
Is it tested? How?
quay.io/ivinokur/che-server:next
image (throws an error on token provisioning).Release Notes
Docs PR