Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logo for the About modal window #916

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: logo for the About modal window #916

merged 1 commit into from
Sep 7, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 7, 2023

What does this PR do?

This PR fixes the Eclipse Che logo for the About modal window.

What issues does this PR fix or reference?

fixes eclipse-che/che#22477

Is it tested? How?

  1. Deploy Eclipse CHE with an image from the current PR.
  2. Added a logo as a base64 encoded image into Custom Resource.
spec:
  components:
    dashboard:
       branding:
         logo:
           base64data: 'PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGhlaWdodD0iNzBweCIgd2lkdGg9IjcwcHgiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDQ3IDU3Ij4KICAgIDxnIGZpbGwtcnVsZT0iZXZlbm9kZCIgc3Ryb2tlPSJub25lIiBzdHJva2Utd2lkdGg9IjEiIGZpbGw9Im5vbmUiPgogICAgICAgIDxwYXRoIGQ9Ik0wLjAzMjIyNywzMC44OGwtMC4wMzIyMjctMTcuMDg3LDIzLjg1My0xMy43OTMsMjMuNzk2LDEzLjc4NC0xNC42OTEsOC41MS05LjA2Mi01LjEwOS0yMy44NjQsMTMuNjk1eiIKICAgICAgICAgICAgICBmaWxsPSIjZmRiOTQwIi8+CiAgICAgICAgPHBhdGggZD0iTTAsNDMuMzU1bDIzLjg3NiwxMy42MjIsMjMuOTc0LTEzLjkzN3YtMTYuOTAybC0yMy45NzQsMTMuNTA2LTIzLjg3Ni0xMy41MDZ2MTcuMjE3eiIgZmlsbD0iIzUyNWM4NiIvPgogICAgPC9nPgo8L3N2Zz4K'
           mediatype: 'image/svg+xml'
  1. Press 'f5' to reload the CHE-dashboard page and open the About modal window.
  2. You should see a new logo:
    Знімок екрана 2023-09-07 о 17 18 35

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-916

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once merged, could you please backport it to 7.74.x for 3.9 ?

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path c571c55 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4 olexii4 merged commit b029795 into main Sep 7, 2023
9 checks passed
@olexii4 olexii4 deleted the CHE-22477 branch September 7, 2023 16:41
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/319: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/320: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4204: FAILURE

dashboard : 3.x ::
; copied to quay

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/321: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/321: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4404 triggered

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Eclipse Che logo from the Custom Resource does not affect the About modal window
5 participants