Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitconfig from UD #928

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Update gitconfig from UD #928

merged 6 commits into from
Sep 21, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Sep 20, 2023

What does this PR do?

Users can now easily view and edit their email and name in the ConfigMap, which holds the gitconfig.

Screencast
Screen.Recording.2023-09-20.at.11.02.20.mov

What issues does this PR fix or reference?

resolves eclipse-che/che#22382

Is it tested? How?

Prereq. If there are no such ConfigMap in your user namespace then you need to create one.

kubectl apply -f - <<EOF
apiVersion: v1
kind: ConfigMap
metadata:
  name: workspace-userdata-gitconfig-configmap
  namespace: <user-namespace>
  labels:
    controller.devfile.io/mount-to-devworkspace: 'true'
    controller.devfile.io/watch-configmap: 'true'
  annotations:
    controller.devfile.io/mount-as: subpath
    controller.devfile.io/mount-path: /etc/
data:
  gitconfig: |
    [user]
    name="<git-user-name>"
    email="<git-user-email>"
EOF
  1. See the screencast

@che-bot
Copy link
Contributor

che-bot commented Sep 20, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-928

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-928

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #928 (4103fb5) into main (5318a18) will increase coverage by 0.32%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   82.26%   82.58%   +0.32%     
==========================================
  Files         351      365      +14     
  Lines       36799    37899    +1100     
  Branches     2356     2412      +56     
==========================================
+ Hits        30271    31300    +1029     
- Misses       6504     6575      +71     
  Partials       24       24              
Flag Coverage Δ
unittests 82.58% <91.89%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/dashboard-backend/src/models/restParams.ts 0.00% <0.00%> (ø)
...kages/dashboard-backend/src/typings/multi-ini.d.ts 0.00% <0.00%> (ø)
...rvices/dashboard-backend-client/devWorkspaceApi.ts 57.41% <ø> (+3.88%) ⬆️
packages/dashboard-frontend/src/store/index.ts 0.00% <0.00%> (ø)
.../services/dashboard-backend-client/gitConfigApi.ts 61.29% <61.29%> (ø)
...ontend/src/components/InputGroupExtended/index.tsx 94.33% <94.33%> (ø)
.../devworkspaceClient/services/gitConfigApi/index.ts 95.97% <95.97%> (ø)
...tend/src/pages/UserPreferences/GitConfig/index.tsx 97.24% <97.24%> (ø)
packages/common/src/dto/api/index.ts 100.00% <100.00%> (ø)
packages/dashboard-backend/src/app.ts 93.27% <100.00%> (+0.17%) ⬆️
... and 15 more

... and 2 files with indirect coverage changes

@olexii4
Copy link
Contributor

olexii4 commented Sep 20, 2023

@akurinnoy I couldn't test it locally:
Знімок екрана 2023-09-20 о 16 15 05

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-928

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 6304930 into main Sep 21, 2023
12 checks passed
@akurinnoy akurinnoy deleted the edit-gitconfig branch September 21, 2023 14:42
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/340: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/341: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/341: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4706 triggered

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/340: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4705 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/1921: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.x/4709: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4507 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.x/2075: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4709 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1382: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4368: SUCCESS

Detected new images: rebuild operator-bundle
* code
* dashboard; /DS_CI/operator-bundle_3.x/2075 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4369: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1382: SUCCESS

3.10.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I want to configure Git username / email from the Dashboard
4 participants