Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework "Backend is not available" error page #930

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Rework "Backend is not available" error page #930

merged 7 commits into from
Oct 6, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 21, 2023

What does this PR do?

Rework the "Backend is not available" error page.

What issues does this PR fix or reference?

fixes eclipse-che/che#22511 and eclipse-che/che#22484

Is it tested? How?

  1. Deploy Eclipse CHE.

  1. Create a new workspace and open the list of workspaces(${che-server}/dashboard/#/workspaces).
  2. Open the dashboard in a new browser tab and press logout.
  3. Return to the first tab and try to delete existing workspaces. It redirects to the login page.

  1. Relogin and open the Preferences page and select Container Registries.
  2. Use a patch oc patch deployment/che -n eclipse-che --patch "{\"spec\":{\"replicas\":0}}" to rolling out Che deployment.
  3. Change selection from Container Registries to Gitconfig.
  4. The following error message will appear: 'HTTP Error code 502. Endpoint which throws an error {che-server}/api/kubernetes/namespace/provision'. Check the browser logs message.'

Знімок екрана 2023-10-05 о 03 58 58

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Sep 21, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #930 (227f30c) into main (443c826) will decrease coverage by 0.30%.
Report is 2 commits behind head on main.
The diff coverage is 59.81%.

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   82.59%   82.30%   -0.30%     
==========================================
  Files         365      364       -1     
  Lines       37941    38046     +105     
  Branches     2414     2450      +36     
==========================================
- Hits        31338    31314      -24     
- Misses       6579     6706     +127     
- Partials       24       26       +2     
Flag Coverage Δ
unittests 82.30% <59.81%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/common/src/helpers/errors.ts 100.00% <100.00%> (ø)
...hboard-frontend/src/Layout/ErrorBoundary/index.tsx 100.00% <100.00%> (ø)
...end/src/components/BannerAlert/WebSocket/index.tsx 96.96% <100.00%> (ø)
...tStartedTab/ImportFromGit/GitRepoLocationInput.tsx 79.23% <ø> (+1.60%) ⬆️
...s/GetStarted/GetStartedTab/ImportFromGit/index.tsx 94.59% <100.00%> (-1.29%) ⬇️
...nd/src/services/backend-client/clusterConfigApi.ts 100.00% <ø> (ø)
...tend/src/services/backend-client/clusterInfoApi.ts 100.00% <ø> (ø)
...oard-frontend/src/services/backend-client/const.ts 100.00% <ø> (ø)
...end/src/services/backend-client/devWorkspaceApi.ts 57.41% <ø> (ø)
...services/backend-client/devWorkspaceTemplateApi.ts 45.00% <ø> (ø)
... and 47 more

... and 2 files with indirect coverage changes

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

@olexii4 olexii4 force-pushed the CHE-22511 branch 2 times, most recently from 9959875 to 9f2f1a4 Compare September 22, 2023 17:15
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

@olexii4 olexii4 marked this pull request as ready for review September 26, 2023 05:04
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

@ibuziuk
Copy link
Member

ibuziuk commented Sep 26, 2023

@olexii4 we should not backport it for 3.9, this change should be only for 3.10

@ibuziuk
Copy link
Member

ibuziuk commented Sep 27, 2023

/retest

@ibuziuk ibuziuk requested a review from ScrewTSW September 27, 2023 11:50
@ibuziuk
Copy link
Member

ibuziuk commented Sep 27, 2023

@ScrewTSW could you please review the PR? The Happy path test seems to be failing again, restarted the job

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, ScrewTSW

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-930

@olexii4 olexii4 merged commit b1b21bd into main Oct 6, 2023
10 of 12 checks passed
@olexii4 olexii4 deleted the CHE-22511 branch October 6, 2023 11:18
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/357: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/357: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4893 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/1981: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.x/4894: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4715 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.x/2133: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4894 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1452: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4538: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2133 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1452: SUCCESS

3.10.0-CI

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/1981: SUCCESS

3.10
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.10-110
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-590167-533291-s390x
  + quay.io/devspaces/iib:3.10-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.10-v4.13-590162-533286-s390x
  + quay.io/devspaces/iib:3.10-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.10-v4.12-590718-533281-s390x
  + quay.io/devspaces/iib:3.10-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.10-v4.11-590707-533277-s390x
  + quay.io/devspaces/iib:3.10-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-590167-533291-ppc64le
  + quay.io/devspaces/iib:3.10-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-590162-533286-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-590718-533281-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-590707-533277-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-590167-533291-x86_64
  + quay.io/devspaces/iib:3.10-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.10-v4.13-590722-533286-x86_64
  + quay.io/devspaces/iib:3.10-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-590718-533281-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-590707-533277-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework "Backend is not available" error page
7 participants