Adding capability to support PKI

[JavaJoeS]

Update with option to install PKI from marketplace, org.eclipse.core.pki

[mickaelistria]

Please use ILog.log().error(e.getMessage(), e)

[JavaJoeS]

@mickaelistria I noticed that most of the other try catch blocks just throw and dont print anything out. There are no other ILog messages in that bundle. Maybe better to stick with the picture show and just throw?

[JavaJoeS]

@mickaelistria Looking again, the software is supposed to be transparent and not required, so perhaps btter to not do anything in the catch block. Software does not even need to know an exception may have occurred.

[merks]

Please 🙏 try to keep a PR to a single commit. Amend and force push further changes. Then you won’t be asked to squash the commits later.

[github-actions]

Test Results

  375 files  +366    375 suites  +366   41m 4s ⏱️ + 8m 42s
1 893 tests  - 304  1 890 ✅  - 303  3 💤  - 1  0 ❌ ±0 
6 679 runs   -   2  6 670 ✅ ±  0  9 💤  - 2  0 ❌ ±0 

Results for commit 2c2b5bc. ± Comparison against base commit c9f0582.

This pull request removes 2165 and adds 1861 tests. Note that renamed tests count towards both.

org.eclipse.equinox.frameworkadmin.tests.Bug196525 ‑ testConfigContent
org.eclipse.equinox.frameworkadmin.tests.Bug258370 ‑ testComma
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testOSGiRemoval
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testSimpleConfiguratorRemoval
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testWithMutipleBundles
org.eclipse.equinox.frameworkadmin.tests.FrameworkExtensionTest ‑ testAddRemoveFrameworkExtension
org.eclipse.equinox.frameworkadmin.tests.LauncherConfigLocationTest ‑ testCustomLauncherConfig
org.eclipse.equinox.frameworkadmin.tests.LauncherDataTest ‑ testRemoveProgramArg
org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug212361_osgiInBundlesList
org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug258126_ProgramArgs_VMArgs
…

AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.Bug196525 ‑ testConfigContent
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.Bug258370 ‑ testComma
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testOSGiRemoval
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testSimpleConfiguratorRemoval
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testWithMutipleBundles
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.FrameworkExtensionTest ‑ testAddRemoveFrameworkExtension
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.LauncherConfigLocationTest ‑ testCustomLauncherConfig
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.LauncherDataTest ‑ testRemoveProgramArg
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug212361_osgiInBundlesList
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug258126_ProgramArgs_VMArgs
…

This pull request removes 4 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.

org.eclipse.equinox.p2.tests.importexport.ImportExportRemoteTests ‑ Unknown test
org.eclipse.equinox.p2.tests.touchpoint.natives.CheckAndPromptNativePackageWindowsRegistryTest ‑ Unknown test
org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testEEIssueSkipsRemediation
org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testSingleIUPreventInstallation

AutomatedTests org.eclipse.equinox.p2.tests.ui.dialogs.AllTests org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testEEIssueSkipsRemediation
AutomatedTests org.eclipse.equinox.p2.tests.ui.dialogs.AllTests org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testSingleIUPreventInstallation
org.eclipse.equinox.p2.tests.importexport.AllTests ‑ org.eclipse.equinox.p2.tests.importexport.ImportExportRemoteTests

♻️ This comment has been updated with latest results.

[JavaJoeS]

@mickaelistria Please recheck..

[laeubi]

Update with option to install PKI from marketplace, org.eclipse.core.pki

I must confess I can't connect that statement to the actual code, the code seem to enable useJREHttp if the default SSL context contains TLS (what else could it be), how is this connected to org.eclipse.core.pki? Why is this doen with P2 transport directly and not with ECF where the actual connection is made?

[JavaJoeS]

@laeubi When there is no PKI enabled the default SSLContext is not TLS.

[laeubi]

Please rebase, squash commits and add documentation somewhere why / what this change does, forcing JRE http does not look "right" just because TLS is enabled (?)