Prevent NPE when no artifact repository is given #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course the usual version bump games kick in... |
merks
approved these changes
Jun 11, 2024
laeubi
force-pushed
the
prevent_npe_if_no_loc_is_given
branch
5 times, most recently
from
723c7ff to
8a25278
Compare
|
@merks sorry for the delay, yes it seems soem version bumps are still required. |
|
@merks actually it is "Error reading manifest for /home/jenkins/agent/workspace/p2_PR-524/.m2/repository/p2/osgi/bundle/bcprov.source/1.78.1/bcprov.source-1.78.1.jar" again not a version bump problem, so I'll rebase... |
laeubi
force-pushed
the
prevent_npe_if_no_loc_is_given
branch
from
8a25278 to
c0131e9
Compare
laeubi
force-pushed
the
prevent_npe_if_no_loc_is_given
branch
from
c0131e9 to
5ac403a
Compare
akurtakov
force-pushed
the
prevent_npe_if_no_loc_is_given
branch
from
5ac403a to
355cb78
Compare
Currently RawMirrorRequest can fail if no repository is given in the descriptor and it want to log a message. P2 should be gracefully in this case and simply report the location as being unknown.
HannesWell
force-pushed
the
prevent_npe_if_no_loc_is_given
branch
from
355cb78 to
1aaa4f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently RawMirrorRequest can fail if no repository is given in the descriptor and it want to log a message.
P2 should be gracefully in this case and simply report the location as being unknown.