[24] Try building the java24 patch on JDT infra

[stephan-herrmann]

Some initial thoughts are in #2899 (comment)

[stephan-herrmann]

One none-standard part of the existing patch-build can be found in java23patch/eclipse.releng.repository.java23patch/patchMatchVersion.xsl

[stephan-herrmann]

Development is happening in git and on jenkins.

The following result can be installed into Eclipse I20241104-1800 (against which it was built: https://ci.eclipse.org/jdt/job/org.eclipse.jdt-patch-feature/9/artifact/eclipse.jdt/org.eclipse.jdt.releng/patchbuild/work/org.eclipse.jdt.java24patch.zip

Unfortunately installation into 4.34M3 fails, despite what looks like a suitable version range.

Further issues:

• the generated feature jar is not yet signed.
• I'm not yet uploading to the download area.

[stephan-herrmann]

Unfortunately installation into 4.34M3 fails, despite what looks like a suitable version range.

Next build based on Y-Build Y20241109-1000 and SDK 4.34M3 can be installed into 4.34M3 (I20241107-0510) and also the next I-build I20241108-1800, see https://ci.eclipse.org/jdt/job/org.eclipse.jdt-patch-feature/10/artifact/eclipse.jdt/org.eclipse.jdt.releng/patchbuild/work/org.eclipse.jdt.java24patch.zip

[stephan-herrmann]

Overview of Steps

The following steps are orchestrated in build.sh :

1. download a specified Eclipse SDK
2. perform some string substitutions to feed build values into text files for the next step
3. invoke PDE Build on just the patch feature
   • this pulls included plugins from the specified Y-build
4. unzip the generated feature from work/buildRepo/features/*.jar back into work/features/ for the next step
   • at this point feature.xml has the correct versions of included plugins
5. re-generate metadata using p2's FeaturesAndBundlesPublisher
6. generate the category using p2's CategoryPublisher
7. tweak the version range, to make the patch applicable to more than just one specific build
   • uses patchMatchVersion.xsl as copied from releng
   • not finding xsltproc on the build machine, this transformation had to be wrapped in an ant build, see patchMatchVersion.xml
8. zip the result (for easier consumption until we push content to download).

All this completes well under one minute.

Building the feature

PDE Build is set up using these files (.in indicates that the file is subject to string substitutions):

• builder/build.properties.in.
  • a few general configuration options for the build
• src/org.eclipse.jdt.java24patch/* + src/feature.xml.in
  • the actual feature definition (nothing special here)
• maps/jdtpatch.map.in
  • this one (after string substitution) declares where elements are to be fetched from:
    • plugins as p2 installable units from the Y-Build URL
    • the feature by copying from the above source folder
• src/category.xml
  • the category definition just like normal.

Generating Metadata

I had a bit of an issue to get metadata including the substitutions from feature.properties (like %featureName...). PDE Build seemed to drop that file, and several ways to invoke the FeaturesAndBundlesPublisher failed, too. By trial and error, the winning invocation is:

• read the feature from source, but with plugin versions already substituted (see step (4) above)
• write output next to the previously generated features/ and plugins/ directories