Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modernization][4.35+] What would it take to make TerminalTokens an enumeration ? #3303

Open
srikanth-sankaran opened this issue Nov 13, 2024 · 2 comments
Open

[Modernization][4.35+] What would it take to make TerminalTokens an enumeration ? #3303

srikanth-sankaran opened this issue Nov 13, 2024 · 2 comments
Labels
Modernization High value non-critical path refactoring efforts

Comments

@srikanth-sankaran
Copy link
Contributor

It would make debugging the parser and scanner SO MUCH easier. What are the complications if any ??
@srikanth-sankaran srikanth-sankaran changed the title [Modernization][4.35+] What would it take to make TerminalTokens enumerations ? [Modernization][4.35+] What would it take to make TerminalTokens an enumeration ? Nov 13, 2024
@iloveeclipse
Copy link
Member

I have no IDE at hand, but I believe there was some code that copied or translated these constants in some "upper" JDT layer constants, see #10.
If that also wkrks with enums, why not.

@iloveeclipse
Copy link
Member

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=576117 for background.

@srikanth-sankaran srikanth-sankaran added the Modernization High value non-critical path refactoring efforts label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Modernization High value non-critical path refactoring efforts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iloveeclipse @srikanth-sankaran