Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures in I-Builds due to less diagnostics being emitted #3356

Closed
srikanth-sankaran opened this issue Nov 26, 2024 · 0 comments · Fixed by #3357
Closed

Test failures in I-Builds due to less diagnostics being emitted #3356

srikanth-sankaran opened this issue Nov 26, 2024 · 0 comments · Fixed by #3357
Assignees
Milestone

Comments

@srikanth-sankaran
Copy link
Contributor

org.eclipse.jdt.ui.tests.quickfix.LocalCorrectionsQuickFixTest has started failing since the merge of #3310 because we emit one less error for:

package pack;

public class E {
	public enum color {
		black, white
	}

	public void foo(color c) {
		switch (c) {
		case (color.black):
			System.out.println("Black");
			break;
		}
	}
}

Basically the new implementation does an early return after having reported Enum constants cannot be surrounded by parenthesis. This results in the other error The qualified case label color.black must be replaced with the unqualified enum constant black from not surfacing.

While it is not a correctness issue - once you fix the only error reported, the second error will surface, it is better to restore older behavior that reports both errors upfront.

@srikanth-sankaran srikanth-sankaran self-assigned this Nov 26, 2024
@srikanth-sankaran srikanth-sankaran added this to the 4.35 M1 milestone Nov 26, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Nov 27, 2024
jarthana added a commit that referenced this issue Dec 6, 2024
* Remove nolonger support converterJclMin (#3332)

Versions older than 1.8 are not supported and thus shouldn't be needed
anymore.

* Fix and enable Java50Tests#testMissingRequiredBinaries

* Version bump(s) for 4.35 stream

* Test failures in I-Builds due to less diagnostics being emitted (#3357)

* Fixes #3356

* Textual problem indicator goes wild with lamda (#3358)

* jclMin23: ignore missing serializable problem

"The serializable class Long does not declare a static final
serialVersionUID field of type"

* Fix FieldLocator and MethodLocator to support local/anonymous classes (#3314)

- Fix FieldLocator.reportDeclaration() and
  MethodLocator.reportDeclaration() to find the anonymous or local
  type for the declaration rather than to return
- add new tests to JavaSearchBugsTests
- fixes #3308

* Codegen Primitives in record comonent patterns to be enabled with null check before calling accessor(#3361)

Before generating an invoke of accessor of a record component, do a null check if primitive conversions are involved.

* java.lang.StackOverflowError during "Requesting Java AST from selection" (#3373)

+ resilience: avoid accepting a sourceType being completed already
+ better hiding of modules seen via the classpath

Fixes #3273

* Add NoSuchFieldError to converterJclMin18 (#3368)

Add NoSuchFieldError to converterJclMin18
 + build the jar
 + avoid new warning

Enable couple of tests fixed by this.

---------
Co-authored-by: Stephan Herrmann <stephan.herrmann@berlin.de>

* Incorrect control flow analysis causes statement subsequent to a switch statement to be flagged unreachable under some circumstances(#3377)

* Fixes #3376

* Remove unused api problem filter

* Update tycho build to 4.0.10

* Completion for unimported types doesn't work.

- use MissingTypesGuesser to select all missing types and offer their completion
- Fixes #1502

* [Enhanced Switch] Wrong error message: Cannot switch on a value of type Integer... at levels that don't support enhanced switch (#3380)

* Fixes #3379

---------

Co-authored-by: Александър Куртаков <akurtakov@gmail.com>
Co-authored-by: Eclipse JDT Bot <jdt-bot@eclipse.org>
Co-authored-by: Srikanth Sankaran <131454720+srikanth-sankaran@users.noreply.github.com>
Co-authored-by: Jörg Kubitz <jkubitz-eclipse@gmx.de>
Co-authored-by: Jeff Johnston <jjohnstn@redhat.com>
Co-authored-by: Manoj  N Palat <manoj.palat@in.ibm.com>
Co-authored-by: Stephan Herrmann <stephan.herrmann@berlin.de>
Co-authored-by: Snjeza <snjezana.peco@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant