2023-09: Error while evaluating 'Array' logical structure for type java.util.Collection with the value 'return toArray();' #309

andy-goryachev-oracle · 2023-09-18T23:13:41Z

To reproduce:

use an existing workspace created with an earlier version
debug any program containing either a list or a map.
set a breakpoint and try to expand an ArrayList or a HashMap in the Variables view.
the node expands, but instead of enumerating the content, it says "Error while evaluating..." (see the two attached screenshots in the comments)

I can see it on macOS with 2023-09.
Is this a resurrection of https://bugs.eclipse.org/bugs/show_bug.cgi?id=559505 ?

This is bad enough, I am forced to downgrade.

Error log:

java.lang.IllegalStateException: The method toArray() is undefined for the type Collection___
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure$EvaluationBlock.log(JavaLogicalStructure.java:200)
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure$EvaluationBlock.evaluate(JavaLogicalStructure.java:149)
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure.getLogicalStructure(JavaLogicalStructure.java:323)
	at org.eclipse.debug.internal.ui.views.variables.LogicalStructureCache$LogicalStructureTypeCache.getLogicalStructure(LogicalStructureCache.java:144)
	at org.eclipse.debug.internal.ui.views.variables.LogicalStructureCache.getLogicalStructure(LogicalStructureCache.java:57)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getLogicalValue(VariableContentProvider.java:215)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getLogicalValue(VariableContentProvider.java:114)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getValueChildren(VariableContentProvider.java:132)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getAllChildren(VariableContentProvider.java:77)
	at org.eclipse.jdt.internal.debug.ui.variables.JavaVariableContentProvider.getAllChildren(JavaVariableContentProvider.java:144)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getChildCount(VariableContentProvider.java:48)
	at org.eclipse.jdt.internal.debug.ui.variables.JavaVariableContentProvider.getChildCount(JavaVariableContentProvider.java:73)
	at org.eclipse.debug.internal.ui.model.elements.ElementContentProvider.retrieveChildCount(ElementContentProvider.java:126)
	at org.eclipse.debug.internal.ui.model.elements.ElementContentProvider$2.run(ElementContentProvider.java:76)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

The text was updated successfully, but these errors were encountered:

andy-goryachev-oracle · 2023-09-18T23:14:41Z

andy-goryachev-oracle · 2023-09-18T23:16:03Z

Session data:

eclipse.buildId=4.29.0.20230907-1200
java.version=20.0.2
java.vendor=Oracle Corporation
BootLoader constants: OS=macosx, ARCH=aarch64, WS=cocoa, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.java.product -keyring /Users/REDACTED/.eclipse_keyring
Command-line arguments:  -os macosx -ws cocoa -arch aarch64 -product org.eclipse.epp.package.java.product -keyring /Users/REDACTED/.eclipse_keyring

andy-goryachev-oracle · 2023-09-18T23:16:30Z

Stack trace for Map:

java.lang.IllegalStateException: The method entrySet() is undefined for the type Map___
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure$EvaluationBlock.log(JavaLogicalStructure.java:200)
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure$EvaluationBlock.evaluate(JavaLogicalStructure.java:149)
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure.getLogicalStructure(JavaLogicalStructure.java:323)
	at org.eclipse.debug.internal.ui.views.variables.LogicalStructureCache$LogicalStructureTypeCache.getLogicalStructure(LogicalStructureCache.java:144)
	at org.eclipse.debug.internal.ui.views.variables.LogicalStructureCache.getLogicalStructure(LogicalStructureCache.java:57)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getLogicalValue(VariableContentProvider.java:215)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getLogicalValue(VariableContentProvider.java:114)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getValueChildren(VariableContentProvider.java:132)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getAllChildren(VariableContentProvider.java:77)
	at org.eclipse.jdt.internal.debug.ui.variables.JavaVariableContentProvider.getAllChildren(JavaVariableContentProvider.java:144)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getChildCount(VariableContentProvider.java:48)
	at org.eclipse.jdt.internal.debug.ui.variables.JavaVariableContentProvider.getChildCount(JavaVariableContentProvider.java:73)
	at org.eclipse.debug.internal.ui.model.elements.ElementContentProvider.retrieveChildCount(ElementContentProvider.java:126)
	at org.eclipse.debug.internal.ui.model.elements.ElementContentProvider$2.run(ElementContentProvider.java:76)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

andy-goryachev-oracle · 2023-09-20T14:58:32Z

Is this the right place to log the issue?

iloveeclipse · 2023-09-20T15:00:09Z

Yes, it is. Please beso kindand attach small self containing example demonstrating the issue.

andy-goryachev-oracle · 2023-09-20T15:06:47Z

Thank you.

I've downgraded my eclipse yesterday, so i cannot provide an SCCE. Updated the description and how to reproduce.

iloveeclipse · 2023-09-20T15:54:30Z

This reminds me on https://bugs.eclipse.org/bugs/show_bug.cgi?id=543604 , but that was fixed long time ago.
I can't reproduce on master, running on Java 20.0.2 / Linux.

import java.util.HashMap;
import java.util.Map;

public class Test {
	public static void main(String[] args) {
		Map<String, String> map = new HashMap<>();
		map.put("key1", "value1");
		map.put("key2", "value2");
		map.put("key3", "value3");
		System.out.println(map);
	}
}

So if you want a fix for your issue, please provide exact steps to reproduce.
May be you can try with the fresh new workspace / clean SDK install etc, may be there are some 3rd party plugins breaking JDT, may be something Mac / Mac JDK specific.

andy-goryachev-oracle · 2023-09-20T16:02:21Z

Interesting, thank you for looking at this!
Would it be possible to check it on macOS on M1 (arm)?
I'll do a clean install later tonight.

iloveeclipse · 2023-09-20T16:05:46Z

Would it be possible to check it on macOS

Not for me, I have no access to any Mac machine.

andy-goryachev-oracle · 2023-09-20T16:30:13Z

Don't see the issue with a clean install and a blank project.
Next will try to open a copy of my old workspace.

SarikaSinha · 2023-09-21T06:09:10Z

Behaviour on Mac:
I was able to reproduce with existing workspace which had just 1 basic java file.
For same install when I switched to new workspace, this error was not there.

andy-goryachev-oracle · 2023-09-27T19:02:44Z

This issue cannot be reproduced when opening (with 2023-09) a clean workspace created with 2023-06.
This indicates that some, possibly much earlier, version leaves the workspace in a state that 2023-09 cannot deal with.

This is still a blocker for migration to 2023-09. Due to corporate restrictions, I cannot attach a copy of the workspace.

iloveeclipse · 2023-09-27T19:13:55Z

I guess you can try to regenerate Java index under Preferences / Java. May be some types aren't properly resolved because of broken / not properly updated index?

andy-goryachev-oracle · 2023-09-27T19:16:42Z

let me try that, but doesn't 'clean all projects' should take care of everything?

iloveeclipse · 2023-09-27T19:18:18Z

No, index is independent from "clean". There are also such things like shared JDK / library symbols etc

andy-goryachev-oracle · 2023-09-27T19:22:36Z

[rebuild index] did not help.
is there a specific file or files in the workspace I need to check?

iloveeclipse · 2023-09-27T19:29:28Z

No. Please note, you need to wait till index is rebuilt before trying.
If this doesn't help, another possibility to play with advanced lookup preference under Java / Debugger.

andy-goryachev-oracle · 2023-09-27T19:39:19Z

waited, even reloaded eclipse.

I respectfully disagree: this is a regression, and a serious one. Pretty much every version since early 2000's could open and work with a workspace created by earlier versions (some even upgraded multiple times) with no issues, at least on my memory. I know it's a complex system, we are also dealing with ever increasing entropy in the Universe, but still - it's a blocker.

What can I do to escalate?

iloveeclipse · 2023-09-27T19:43:16Z

What can I do to escalate?

Well, if your organization is member of Eclipse IDE working group, you could ask your representative in that group to raise the priority of this issue on the next IDE WG meeting.

Or you can ask your organization to hire some developer to debug & fix this issue.

andy-goryachev-oracle · 2023-10-04T17:46:46Z

Unfortunately, my organization is not a member of Eclipse IDE working group.

jukzi · 2024-02-14T13:33:15Z

How to Become a Member:
https://eclipseide.org/membership/

alerosmile · 2024-03-06T19:12:24Z

Same here with 2023-12. I get this if the application is started as modular only. That is if the application is modular itself or inside a workspace dependency if it is modular.

andy-goryachev-oracle · 2024-03-06T19:23:52Z

How to Become a Member:

not an option for my org, unfortunately.

andy-goryachev · 2024-03-06T19:29:09Z

That is if the application is modular itself or inside a workspace dependency if it is modular.

Thank you, you might be on something!
This was the case for the original report. The other project I tried wasn't a modular one.

andy-goryachev · 2024-04-05T15:11:14Z

@iloveeclipse
please remove [needinfo] label. the issue is still present in 2024-03 version, and as @alerosmile mentioned it occurs in any modular project.

iloveeclipse · 2024-04-05T15:14:41Z

@iloveeclipse please remove [needinfo] label. the issue is still present in 2024-03 version, and as @alerosmile mentioned it occurs in any modular project.

I don't see exact steps to reproduce yet, sorry. If someone can provide something that I (or anyone else) would be able to reproduce, I would remove "needinfo".

andy-goryachev-oracle · 2024-04-05T15:28:42Z

okay, here are the steps:

macOS 14.4.1 on M1
launch eclipse 2024-03
create a brand new workspace
create a new java project (see a screenshot later in the comments)
create a new java class (screenshot, code later in the comments)
set a breakpoint on line 10.
debug (screenshot)

observe the error:

java.lang.IllegalStateException: The method entrySet() is undefined for the type Map___
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure$EvaluationBlock.log(JavaLogicalStructure.java:194)
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure$EvaluationBlock.evaluate(JavaLogicalStructure.java:143)
	at org.eclipse.jdt.internal.debug.core.logicalstructures.JavaLogicalStructure.getLogicalStructure(JavaLogicalStructure.java:317)
	at org.eclipse.debug.internal.ui.views.variables.LogicalStructureCache$LogicalStructureTypeCache.getLogicalStructure(LogicalStructureCache.java:143)
	at org.eclipse.debug.internal.ui.views.variables.LogicalStructureCache.getLogicalStructure(LogicalStructureCache.java:56)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getLogicalValue(VariableContentProvider.java:211)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getLogicalValue(VariableContentProvider.java:111)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getValueChildren(VariableContentProvider.java:128)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getAllChildren(VariableContentProvider.java:76)
	at org.eclipse.jdt.internal.debug.ui.variables.JavaVariableContentProvider.getAllChildren(JavaVariableContentProvider.java:143)
	at org.eclipse.debug.internal.ui.model.elements.VariableContentProvider.getChildCount(VariableContentProvider.java:48)
	at org.eclipse.jdt.internal.debug.ui.variables.JavaVariableContentProvider.getChildCount(JavaVariableContentProvider.java:73)
	at org.eclipse.debug.internal.ui.model.elements.ElementContentProvider.retrieveChildCount(ElementContentProvider.java:122)
	at org.eclipse.debug.internal.ui.model.elements.ElementContentProvider$2.run(ElementContentProvider.java:76)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

andy-goryachev-oracle · 2024-04-08T18:19:35Z

here is the complete test case:

ModularTest.zip

andy-goryachev-oracle · 2024-04-08T18:54:16Z

tried with eclipse-SDK-4.32M1-macosx-cocoa-aarch64.dmg
copied from .dmb to an empty directory, launched from there, opened the workspace.

same issue. I think, as @alerosmile has identified, the issue might be caused by a modular project (notice module-info.java in the zip I've sent earlier).

iloveeclipse · 2024-04-08T18:57:26Z

Thanks, I can't promise but I will try to debug this this week.

andy-goryachev · 2024-04-08T19:01:42Z

many thanks indeed!

alerosmile · 2024-04-09T07:19:34Z

@andy-goryachev-oracle: Can you please confirm that this issue doesn't exist with Eclipse 2023-06?

andy-goryachev-oracle · 2024-04-09T15:04:03Z

Yes, it works with built-in JDK17 and JDK21, using Eclipse 4.28.0.20230608-1200 downloaded from
https://www.eclipse.org/downloads/packages/release/2023-06/r

alerosmile · 2024-04-09T18:35:28Z

Changing this line to OPTION_JdtDebugCompileMode will fix the error.

But as stated in this commit, this option seems to cause side effects I don't have knowledge of.

iloveeclipse · 2024-04-11T15:50:42Z

OK, finally got time to test the reproducer.
I confirm this is easily reproducible, and related to #260 change.

What was surprising for me: if testing in a Java perspective (with Variables view not activated), the hover over variables shows proper (but not "logical") content without errors.
Only after opening Variables view the hover "remembers" it should actually show logical structures and starts to misbehave. So we have another bug here, but that's not important one.

alerosmile · 2024-04-11T15:56:02Z

Isn't that intentional? If I change the option in the Variables view, the way the data is displayed on the hover should change as well.

iloveeclipse · 2024-04-11T16:08:44Z

Yes, but the hover should be able to understand that preference, if it is set, without Variables view being active.
But please let us discuss the original issue, my fault to add this observation here.

Looking on the code in debugger I see that the two options used differently (well, they are different :-)).

https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java#L219

https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java#L221

@stephan-herrmann : your brain is needed, as it is all about #260 and OPTION_IgnoreUnnamedModuleForSplitPackage not being enough to replace OPTION_JdtDebugCompileMode.

May I ask you to look into this issue? Example self contained project is in https://github.com/eclipse-jdt/eclipse.jdt.debug/files/14909705/ModularTest.zip

stephan-herrmann · 2024-04-11T21:37:13Z

@stephan-herrmann : your brain is needed, as it is all about #260 and OPTION_IgnoreUnnamedModuleForSplitPackage not being enough to replace OPTION_JdtDebugCompileMode.

May I ask you to look into this issue? Example self contained project is in https://github.com/eclipse-jdt/eclipse.jdt.debug/files/14909705/ModularTest.zip

ack

stephan-herrmann · 2024-04-13T11:00:14Z

Any chance to debug this in a JUnit test case?

I briefly looked if I could create that test case, but after finding JDT Debug Evaluation Test Suite.launch as the most promising point to start from, I couldn't even get that launch configuration to run any tests. A fresh workbench window opens, and all it does is wait for user input.

stephan-herrmann · 2024-04-13T11:18:40Z

Initial compile error:
The package java.util is accessible from more than one module: ModularTest, java.base

So, contrary to what we discussed in eclipse-jdt/eclipse.jdt.core#445 the requirement by JDT/Debug is not just about allowing an unnamed/named module conflict, but also a conflict between two named modules should be ignored, right?

The former would be covered by OPTION_IgnoreUnnamedModuleForSplitPackage but the latter would never be acceptable during compilation proper, and hence no user-visible option will sanction this situation.

Is it a hard requirement in JDT/Debug to place the synthetic type Map___ into package java.util and into the current JavaProject? This obviously violates a few Java rules, unless we could tweak the structure in a way that options like --patch-module could be used.

I would indeed prefer a solution that could be made legal wrt JPMS.

If that fails, going back to and fixing OPTION_JdtDebugCompileMode would be a pragmatic approach.

stephan-herrmann · 2024-04-13T13:10:43Z

I would indeed prefer a solution that could be made legal wrt JPMS.

I didn't find an easy solution down this path.

If that fails, going back to and fixing OPTION_JdtDebugCompileMode would be a pragmatic approach.

See eclipse-jdt/eclipse.jdt.core#2340

OPTION_IgnoreUnnamedModuleForSplitPackage" This reverts commit f52ee57 as it caused regression. See eclipse-jdt#260 See also eclipse-jdt/eclipse.jdt.core#2340 Fixes eclipse-jdt#309

OPTION_IgnoreUnnamedModuleForSplitPackage" This reverts commit f52ee57 as it caused regression. See #260 See also eclipse-jdt/eclipse.jdt.core#2340 Fixes #309

iloveeclipse · 2024-04-14T11:33:12Z

@stephan-herrmann : once again, many thanks!

Tomorrow I-build on https://download.eclipse.org/eclipse/downloads/ should have the fix for the ticket.

stephan-herrmann · 2024-04-14T12:17:56Z

@stephan-herrmann : once again, many thanks!

You're welcome 😄
... and sorry for proposing the use of OPTION_IgnoreUnnamedModuleForSplitPackage in the first place.

iloveeclipse · 2024-04-15T08:19:25Z

Verified, works fine with I20240414-1800

andy-goryachev-oracle changed the title ~~Error while evaluating 'Array' logical structure for type java.util.Collection with the value 'return toArray();'~~ 2023-09: Error while evaluating 'Array' logical structure for type java.util.Collection with the value 'return toArray();' Sep 18, 2023

andy-goryachev-oracle mentioned this issue Sep 19, 2023

8314906: [testbug] Create behavior tests for text input controls openjdk/jfx#1221

Closed

3 tasks

iloveeclipse added the needinfo Further information is requested label Sep 20, 2023

iloveeclipse added the regression Regression from previous release label Apr 11, 2024

iloveeclipse mentioned this issue Apr 11, 2024

OPTION_JdtDebugCompileMode has surprising effects on imports eclipse-jdt/eclipse.jdt.core#445

Closed

This was referenced Apr 13, 2024

Replace use of OPTION_JdtDebugCompileMode with OPTION_IgnoreUnnamedModuleForSplitPackage #260

Closed

OPTION_JdtDebugCompileMode has surprising effects on imports eclipse-jdt/eclipse.jdt.core#1141

Closed

This was referenced Apr 14, 2024

Revert "Remove use of OPTION_JdtDebugCompileMode with OPTION_IgnoreUnnamedModuleForSplitPackage" #428

Merged

Remove use of OPTION_JdtDebugCompileMode with OPTION_IgnoreUnnamedModuleForSplitPackage #261

Merged

iloveeclipse assigned iloveeclipse and stephan-herrmann Apr 14, 2024

iloveeclipse removed the help wanted Extra attention is needed label Apr 14, 2024

iloveeclipse added this to the 4.32 M2 milestone Apr 14, 2024

iloveeclipse closed this as completed in #428 Apr 14, 2024

iloveeclipse added a commit that referenced this issue Apr 14, 2024

Revert "Remove use of OPTION_JdtDebugCompileMode with

61a610f

OPTION_IgnoreUnnamedModuleForSplitPackage" This reverts commit f52ee57 as it caused regression. See #260 See also eclipse-jdt/eclipse.jdt.core#2340 Fixes #309

2023-09: Error while evaluating 'Array' logical structure for type java.util.Collection with the value 'return toArray();' #309

2023-09: Error while evaluating 'Array' logical structure for type java.util.Collection with the value 'return toArray();' #309

Comments

andy-goryachev-oracle commented Sep 18, 2023 • edited Loading

andy-goryachev-oracle commented Sep 18, 2023

andy-goryachev-oracle commented Sep 18, 2023

andy-goryachev-oracle commented Sep 18, 2023

andy-goryachev-oracle commented Sep 20, 2023

iloveeclipse commented Sep 20, 2023

andy-goryachev-oracle commented Sep 20, 2023

iloveeclipse commented Sep 20, 2023

andy-goryachev-oracle commented Sep 20, 2023

iloveeclipse commented Sep 20, 2023

andy-goryachev-oracle commented Sep 20, 2023

SarikaSinha commented Sep 21, 2023

andy-goryachev-oracle commented Sep 27, 2023

iloveeclipse commented Sep 27, 2023

andy-goryachev-oracle commented Sep 27, 2023

iloveeclipse commented Sep 27, 2023

andy-goryachev-oracle commented Sep 27, 2023

iloveeclipse commented Sep 27, 2023

andy-goryachev-oracle commented Sep 27, 2023

iloveeclipse commented Sep 27, 2023

andy-goryachev-oracle commented Oct 4, 2023

jukzi commented Feb 14, 2024 • edited Loading

alerosmile commented Mar 6, 2024

andy-goryachev-oracle commented Mar 6, 2024

andy-goryachev commented Mar 6, 2024

andy-goryachev commented Apr 5, 2024

iloveeclipse commented Apr 5, 2024

andy-goryachev-oracle commented Apr 5, 2024 • edited Loading

andy-goryachev-oracle commented Apr 8, 2024

andy-goryachev-oracle commented Apr 8, 2024

iloveeclipse commented Apr 8, 2024

andy-goryachev commented Apr 8, 2024

alerosmile commented Apr 9, 2024

andy-goryachev-oracle commented Apr 9, 2024

alerosmile commented Apr 9, 2024

iloveeclipse commented Apr 11, 2024

alerosmile commented Apr 11, 2024

iloveeclipse commented Apr 11, 2024

stephan-herrmann commented Apr 11, 2024

stephan-herrmann commented Apr 13, 2024

stephan-herrmann commented Apr 13, 2024

stephan-herrmann commented Apr 13, 2024

iloveeclipse commented Apr 14, 2024

stephan-herrmann commented Apr 14, 2024

iloveeclipse commented Apr 15, 2024

andy-goryachev-oracle commented Sep 18, 2023 •

edited

Loading

jukzi commented Feb 14, 2024 •

edited

Loading

andy-goryachev-oracle commented Apr 5, 2024 •

edited

Loading