Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23] Allow JDT to target Java 23 in compiler preferences #1349

Closed
noopur2507 opened this issue Apr 23, 2024 · 6 comments
Closed

[23] Allow JDT to target Java 23 in compiler preferences #1349

noopur2507 opened this issue Apr 23, 2024 · 6 comments
Assignees
Milestone

Comments

@noopur2507
Copy link
Member

Allow JDT to target Java 23 in compiler preferences.

@noopur2507 noopur2507 self-assigned this Apr 23, 2024
@noopur2507 noopur2507 added this to the BETA_JAVA23 milestone Apr 23, 2024
akurtakov pushed a commit to akurtakov/eclipse.jdt.ui that referenced this issue Apr 30, 2024
akurtakov pushed a commit to akurtakov/eclipse.jdt.ui that referenced this issue May 8, 2024
@howlger
Copy link
Contributor

howlger commented Jun 1, 2024

With this change, in the Eclipse SDK 4.32 RC2, in the New Java Project dialog, in the Use an execution environment JRE: drop-down menu JavaSE-23 is offered as an option. When in the preferences Java > Installed JREs, an OpenJDK JDK 23 early-access build is configured, creating a new Java project with JRE System Library [JavaSE-23] works fine for me. However, the .class files generated by ecj in the bin folder will have the Java class file version 66 (Java 22) instead of 67 (Java 23).

Is this intended? If so, is there more information (what was the motivation to do this; why is this not labeled as beta; will this be done also for future versions; etc.)?

@iloveeclipse
Copy link
Member

It is a bug, it shouldn't be offered in 4.32.

@howlger
Copy link
Contributor

howlger commented Jun 2, 2024

It is a bug, it shouldn't be offered in 4.32.

Will it be fixed in the 4.32 release, or is it too late now?

@iloveeclipse
Copy link
Member

Will it be fixed in the 4.32 release, or is it too late now?

Too late.

@noopur2507
Copy link
Member Author

The PR with this issue was merged only in the BETA_JAVA23 branch and I don't see these code changes in the master branch either. Also, these changes should not have an impact on the New Java Project wizard and are only for the Compiler preferences.

@noopur2507
Copy link
Member Author

With this change, in the Eclipse SDK 4.32 RC2, in the New Java Project dialog, in the Use an execution environment JRE: drop-down menu JavaSE-23 is offered as an option. When in the preferences Java > Installed JREs, an OpenJDK JDK 23 early-access build is configured, creating a new Java project with JRE System Library [JavaSE-23] works fine for me. However, the .class files generated by ecj in the bin folder will have the Java class file version 66 (Java 22) instead of 67 (Java 23).

Is this intended? If so, is there more information (what was the motivation to do this; why is this not labeled as beta; will this be done also for future versions; etc.)?

Probably a result of eclipse-jdt/eclipse.jdt.debug#419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants