Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code mining] Consider adding JUnit minings / debugging minings #1798

Open
JanecekPetr opened this issue Nov 13, 2024 · 4 comments
Open

[code mining] Consider adding JUnit minings / debugging minings #1798

JanecekPetr opened this issue Nov 13, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@JanecekPetr
Copy link

The original code mining repo, https://github.com/angelozerr/jdt-codemining, has a few more tricks than the current JDT. Namely,

Are we considering adding any of those? I'd gladly help with asking for permission from the original author, if needed, and integrating the cleaned-up code into JDT if that helps in any way.

@jukzi jukzi added the enhancement New feature or request label Nov 13, 2024
@jukzi
Copy link
Contributor

jukzi commented Nov 13, 2024

Maybe you can share a screenshot what it would look like?
Is there a reason why it should be implemented in JDT instead of a plugin on top?

@carstenartur
Copy link
Contributor

What contribution is welcome and where do you prefer it to be kept separate? In fact I was thinking about contributing a cleanup to migrate junit 4 to junit 5. definitly this is junit specific. On the other side there is already a lot of junit specific code in jdt and jdts test itself are based on junit too.
See carstenartur/sandbox#110

@jukzi
Copy link
Contributor

jukzi commented Nov 14, 2024

Good question, I'd say java specific thinks belong to the scope of JDT.UI. JUnit does not, but is interesting for the eclipse ide as a whole. I actually would try to use it to convert SWT to junit 5. The problem i see is that as the codebase grows it is hard to maintain. Often edge cases remain unsolved which gives a bad light on jdt.

@carstenartur
Copy link
Contributor

Imho the strong connection of junit and Eclipse is a strength and has a reason: Erich Gamma, famous member of the gang of four and involved in the early days of Eclipse and JUnit at the same time.

https://www.infoq.com/interviews/gamma-jazz-eclipse-junit-design-patterns/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants