-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kuksa-can-provider #16
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think the names and config look good. Question: As we are not so much in to DDS provider currently, will this be the first to move? Or should we go for CAN first, and then maybe something like CSV or GPS? I just wonder why you chose to include DDS in this PR already as opposed to others |
kuksa-can-provider intended to be the new home of https://github.com/eclipse/kuksa.val.feeders/tree/main/dbc2val Intentionally no branch protection from start. To be added later when migration has been verified and finished.
Diff for f0a60f2:Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'
Actions are indicated with the following symbols:
+ create
! modify
! forced update
- delete
Organization eclipse-kuksa[id=eclipse-kuksa]
+ add repository[name="kuksa-can-provider"] {
+ allow_auto_merge = false
+ allow_forking = true
+ allow_merge_commit = true
+ allow_rebase_merge = true
+ allow_squash_merge = true
+ allow_update_branch = false
+ archived = false
+ default_branch = "main"
+ delete_branch_on_merge = false
+ dependabot_alerts_enabled = true
+ dependabot_security_updates_enabled = true
+ description = null
+ gh_pages_build_type = "disabled"
+ has_discussions = false
+ has_issues = true
+ has_projects = true
+ has_wiki = true
+ homepage = null
+ is_template = false
+ merge_commit_message = "PR_TITLE"
+ merge_commit_title = "MERGE_MESSAGE"
+ name = "kuksa-can-provider"
+ private = false
+ secret_scanning = "enabled"
+ secret_scanning_push_protection = "enabled"
+ squash_merge_commit_message = "COMMIT_MESSAGES"
+ squash_merge_commit_title = "COMMIT_OR_PR_TITLE"
+ template_repository = null
+ topics = []
+ web_commit_signoff_required = false
+ }
+ add repo_workflow_settings[repository="kuksa-can-provider"] {
+ actions_can_approve_pull_request_reviews = false
+ allowed_actions = "all"
+ default_workflow_permissions = "read"
+ enabled = true
+ }
Plan: 2 to add, 0 to change, 0 to delete. Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'
Organization eclipse-kuksa[id=eclipse-kuksa]
--- original
+++ canonical
@@ -1,17 +1,22 @@
local orgs = import 'vendor/otterdog-defaults/otterdog-defaults.libsonnet';
+
+local kuksa_default_branch_protection_rule(pattern) =
+ orgs.newBranchProtectionRule(pattern) {
+
+
+ dismisses_stale_reviews: true
+ require_last_push_approval: true
+ required_approving_review_count: 1
+ requires_strict_status_checks: true
+ };
orgs.newOrg('eclipse-kuksa') {
_repositories+:: [
orgs.newRepo('kuksa-actions') {
allow_merge_commit: true
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
delete_branch_on_merge: false
dependabot_security_updates_enabled: true
@@ -26,12 +31,7 @@
allow_squash_merge: false
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
dependabot_security_updates_enabled: true
web_commit_signoff_required: false
@@ -45,12 +45,7 @@
allow_squash_merge: false
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
dependabot_security_updates_enabled: true
web_commit_signoff_required: false
@@ -72,12 +67,7 @@
allow_merge_commit: true
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
delete_branch_on_merge: false
dependabot_security_updates_enabled: true
@@ -100,12 +90,7 @@
allow_merge_commit: true
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
delete_branch_on_merge: false
dependabot_alerts_enabled: false
@@ -120,12 +105,7 @@
allow_merge_commit: true
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
delete_branch_on_merge: false
dependabot_security_updates_enabled: true
@@ -138,12 +118,7 @@
allow_merge_commit: true
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('main') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('main')
]
delete_branch_on_merge: false
dependabot_security_updates_enabled: true
@@ -156,12 +131,7 @@
allow_merge_commit: true
allow_update_branch: false
branch_protection_rules: [
- orgs.newBranchProtectionRule('master') {
- dismisses_stale_reviews: true
- require_last_push_approval: true
- required_approving_review_count: 1
- requires_strict_status_checks: true
- }
+ kuksa_default_branch_protection_rule('master')
]
default_branch: "master"
delete_branch_on_merge: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
change is live. |
kuksa-can-provider intended to be the new home of
https://github.com/eclipse/kuksa.val.feeders/tree/main/dbc2val
Intentionally no branch protection from start.
To be added later when migration has been verified and finished.
To be merged first after approval of @SebastianSchildt or @lukasmittag