Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(TestApp): Remove Field.METADATA from "casual" queries #59

Merged
merged 6 commits into from
Jan 30, 2024
Merged

feature(TestApp): Remove Field.METADATA from "casual" queries #59

merged 6 commits into from
Jan 30, 2024

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Dec 6, 2023

Splitting up fetching the FIELD_TYPE and fetching the actual
query from the user into two separate ones.
Unfortunately this did not fix the crash when logging vehicle
because the json contained to many lineBreaks ("\n").

Closes: #24

wba2hi added 2 commits December 6, 2023 14:40
@wba2hi
feature(TestApp): Remove Field.METADATA from "casual" queries
fac8d85 
Splitting up fetching the FIELD_TYPE and fetching the actual
query from the user into two separate ones.
Unfortunately this did not fix the crash when logging vehicle
because the json contained to many lineBreaks ("\n").

Closes: eclipse-kuksa#24
Signed-off-by: Andre Weber <andre.weber3@etas.com>
@wba2hi
chore: Improve Log Output
480f17f 
Fixing the crash when logging "Vehicle". Instead of outputting one
big log chunk outputting multiple smaller ones.

Signed-off-by: Andre Weber <andre.weber3@etas.com>
@Chrylo
Copy link
Contributor

Chrylo commented Dec 14, 2023

Maybe we can fix it in this ticket also:
When fetching the "Vehicle" vss path then the automatic value type is "float" because the .metadata extension is returning the first result (Maybe we should rename that to be clearer and/or returning a list of metadata - I suggest doing both). The result should probably be "VALUE_NOT_SET" if the type is ambiguous (More than one meta data)

@wba2hi
Copy link
Contributor Author

wba2hi commented Jan 15, 2024

Maybe we can fix it in this ticket also: When fetching the "Vehicle" vss path then the automatic value type is "float" because the .metadata extension is returning the first result (Maybe we should rename that to be clearer and/or returning a list of metadata - I suggest doing both). The result should probably be "VALUE_NOT_SET" if the type is ambiguous (More than one meta data)

Will take a look at it and check if it's an easy fix or not :)

Chrylo
Chrylo approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Chrylo Chrylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Additional fix:
The type field now shows correctly "VALUE NOT SET" when ambiguous meta data are received.

@Chrylo Chrylo merged commit 47004e0 into eclipse-kuksa:main Jan 30, 2024
5 checks passed
@Chrylo Chrylo deleted the feature-24 branch January 30, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrylo Chrylo Chrylo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestApp: Remove Field.METADATA from "casual" queries - only use it to set the DataType
2 participants
@wba2hi @Chrylo