Deadlock in DefaultProjectBuildingHelper

[laeubi]

I did some modification to the pom.xml and requested to save, then suddenly my IDE was blocked for several minutes (approx 5mintes then it seems to do something and is again blocked) I recorded the attached thread dump that shows a block in org.apache.maven.project.DefaultProjectBuildingHelper.createProjectRealm.

I attach two dumps, one from eclipse and one from the XMLServerLauncher process that jps is showing me
Eclipse2.txt
XMLServerLauncher2.txt
Eclipse.txt
XMLServerLauncher.txt
.

[laeubi]

I think I somehow triggered this by using an invalid version property like <version>${does-not-exits}</version>

[laeubi]

The UI Lock is actually caused by eclipse-platform/eclipse.platform.runtime#40

[mickaelistria]

So now that eclipse-platform/eclipse.platform.runtime#40 is resolved, can we close this issue?

[laeubi]

I think the UI-Lock will be fixed, but the issue remains that the XMLServerLauncher seem to be very slow here? I see a lot of waiting and blocked here ...

[mickaelistria]

Yes, there is indeed a case, that's not yet clearly identified and even less fixed, where lemminx-maven is stuck.

[laeubi]

If you think this is not enough information we still can close this for now and I'll try to capture new dumps with the fixed behavior.

From my experience, it seems that lemminx do not likes "invalid" versions and easily performs a lot of stuff to find things that are not present. I know that's rather vague, but I mostly notice such hands, e.g. when I e.g type something like <version>${misspelled.property.for.version}</version> then also sometimes annoying error dialog popup telling that there are errors reading java-doc and sources and things seem to go mad. I don't know if there are some kind of "valid chars" for a version and one might check if at least it seems to be a valid one ...

[vrubezhny]

@laeubi Could you please check at least if org.eclipse.m2e.editor.lemminx plugin of version >= 2.0.1 is installed in your Eclipse? Version 2.0.1 should embed the fixed lemminx-maven version.

** Plug-in Registry:
org.eclipse.m2e.editor.lemminx (2.0.1.20221120-2121) "M2E Maven POM File Editor using Wild Web Developer, Lemminx and Maven LS extension (requires Incubating components)" [Resolved]

And if you already have this version installed (or if you would update to it) could you please try reproducing the issue again?

[vrubezhny]

Too many changes happen in the project since the issue was created, I believe this is not a recent issue anymore.
Please feel free to open a new issue if anything similar happens when using the latest released version. Thanks!