Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of URI class to identify endpoint. #1582

Closed
sbernard31 opened this issue Feb 5, 2024 · 1 comment
Closed

Replace usage of URI class to identify endpoint. #1582

sbernard31 opened this issue Feb 5, 2024 · 1 comment
Labels
core Impact core of Leshan enhancement Improvement of existing features

Comments

@sbernard31
Copy link
Contributor

sbernard31 commented Feb 5, 2024

Since we introduce the new transport layer abstraction, we identify endpoint by URI using java.net.URI.

There is some argument to replace this by a String or a dedicated new class (EndpointURI ?).

Here is a list of those arguments :

Spring project goes to the conclusion that URI class has lot of issue and should be replaced :

In fact, one of the reasons for introducing UriComponents in Spring Framework was because java.net.URI had known encoding issues, which meant that we had to create our own abstraction that did follow the related RFCs. And as mentioned above, accepting the % is one thing, but it really should be encoded on output, in accordance with RFC 6874.

(The % point issue is relative to Leshan issue : #1580 (comment))

@sbernard31
Copy link
Contributor Author

It should be fixed by #1648 (will be available in 2.0.0-M17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Impact core of Leshan enhancement Improvement of existing features
Projects
None yet
Development

No branches or pull requests

1 participant