Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LWM2M Model Validation. #835

Closed
sbernard31 opened this issue Apr 22, 2020 · 3 comments
Closed

Improve LWM2M Model Validation. #835

sbernard31 opened this issue Apr 22, 2020 · 3 comments
Labels
bsserver Impact LWM2M bootstrap server client Impact LWM2M client new feature New feature from LWM2M specification server Impact LWM2M server

Comments

@sbernard31
Copy link
Contributor

#833 reveals some issue about LWM2M Model.
Most important one was fixed in #834 without any API break for the 1.0.x.

But we should consider more API impacting improvement for 1.1 or 2.0, like :

  • create a LWM2M Model Validator which should be used to avoid to load invalid model in a LWM2M server or client.
  • Eventually use the Validator for DDFFileParser to log issue.
  • DDFFileParser should use XML schema for validation too.
  • create a NONE value for Type enum for more consistency.
@sbernard31 sbernard31 added new feature New feature from LWM2M specification client Impact LWM2M client server Impact LWM2M server bsserver Impact LWM2M bootstrap server labels Apr 22, 2020
@sbernard31 sbernard31 mentioned this issue Apr 22, 2020
Closed
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: Add DDF file validator (validate againts LWM2M.xsd)
4b17c83
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: Add URN utility class
71f547c
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: add URN, description2 and lwm2mVersion field to ObjectModel
85c2108
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: DDFFileParser support urn, description2 and lwm2mVersion
db1ff16
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: raise exception if DDF file parsing failed.
ed4a70e
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: Add ObjectModelValidator class to validate object model
f7bfe8c
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: add load function with validation to ObjectLoader
7183591
sbernard31 added a commit that referenced this issue Jun 11, 2020
@sbernard31
#835: validate model before to use it in Leshan server and client demo
c041275
@sbernard31 sbernard31 mentioned this issue Jun 11, 2020
Merged
@sbernard31
Copy link
Contributor Author

@chelmertz I added a lot model validation feature with #851. You could have a look if you are interested.

@sbernard31
Copy link
Contributor Author

@jpradocueva I added some LWM2M Model/ DDF file validation tooling in Leshan (see #851)
Maybe this could be useful for OMA to validate your model ? (I guess you probably have some tooling for that but I share this with you just in case)

sbernard31 added a commit that referenced this issue Jun 15, 2020
@sbernard31
#835: Add ObjectModelValidator class to validate object model
8b47767
sbernard31 added a commit that referenced this issue Jun 15, 2020
@sbernard31
#835: add load function with validation to ObjectLoader
0aff03b
sbernard31 added a commit that referenced this issue Jun 15, 2020
@sbernard31
#835: validate model before to use it in Leshan server and client demo
b755189
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: Add DDF file validator (validate againts LWM2M.xsd)
ecbd0ca
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: Add URN utility class
8885bb1
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: add URN, description2 and lwm2mVersion field to ObjectModel
d1faa9a
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: DDFFileParser support urn, description2 and lwm2mVersion
955d7cd
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: raise exception if DDF file parsing failed.
3cd7ad2
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: Add ObjectModelValidator class to validate object model
064ea5f
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: add load function with validation to ObjectLoader
0b9d34c
sbernard31 added a commit that referenced this issue Jun 23, 2020
@sbernard31
#835: validate model before to use it in Leshan server and client demo
c3baf6f
@sbernard31
Copy link
Contributor Author

#851 is now integrated in master. (will be available in 1.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bsserver Impact LWM2M bootstrap server client Impact LWM2M client new feature New feature from LWM2M specification server Impact LWM2M server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbernard31