-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR build limitation: test framework takes the default extension repo branch instead of current change #17595
Comments
Looking at a grinder, the parameters for test are JDK_REPO and JDK_BRANCH. At the top level job (https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK11_aarch64_linux/1475/console) we see @AdamBrousseau said: So the ask is that any PR build that changes code in extensions, should pass JDK_REPO & JDK_BRANCH to the test jobs. Correct? I'm not sure I was thinking of the same known issue originally. |
Yes, we need set JDK_REPO and JDK_BRANCH for the extensions repos in the test job.
The test job takes JDK_REPO, JDK_BRANCH and OPENJDK_SHA. If the correct ref is passed in, the test job is able to get the extension repo materials. |
Copied from
extended.openjdk
PR build still shows the errors #16074 due to the test framework taking the default JDK19 extension repo instead of this PR.Launched an internal grinder w/ this change and the three tests in question are skipped or passed.
Originally posted by @JasonFengJ9 in ibmruntimes/openj9-openjdk-jdk19#34 (comment)
Related issues
Internal issue - OpenJ9 pipelines should pass openjdk repo/branch to test jobs
The text was updated successfully, but these errors were encountered: