Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR build limitation: test framework takes the default extension repo branch instead of current change #17595

Open
JasonFengJ9 opened this issue Jun 14, 2023 · 2 comments

Comments

@JasonFengJ9
Copy link
Member

Copied from

extended.openjdk PR build still shows the errors #16074 due to the test framework taking the default JDK19 extension repo instead of this PR.
Launched an internal grinder w/ this change and the three tests in question are skipped or passed.

Originally posted by @JasonFengJ9 in ibmruntimes/openj9-openjdk-jdk19#34 (comment)

Related issues

Internal issue - OpenJ9 pipelines should pass openjdk repo/branch to test jobs

@pshipton
Copy link
Member

Looking at a grinder, the parameters for test are JDK_REPO and JDK_BRANCH. At the top level job (https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK11_aarch64_linux/1475/console) we see
09:39:38 Using OPENJDK_REPO = https://github.com/ibmruntimes/openj9-openjdk-jdk11.git OPENJDK_BRANCH = openj9
In the test job (https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_Personal/20/consoleFull), there is no mention of these parameters.

@AdamBrousseau said:

So the ask is that any PR build that changes code in extensions, should pass JDK_REPO & JDK_BRANCH to the test jobs. Correct? I'm not sure I was thinking of the same known issue originally.
Does the test code have ability at the moment to fetch PR refs and checkout a merge ref of extensions repos @llxia?

@llxia
Copy link
Contributor

llxia commented Jun 15, 2023

So the ask is that any PR build that changes code in extensions, should pass JDK_REPO & JDK_BRANCH to the test jobs. Correct?

Yes, we need set JDK_REPO and JDK_BRANCH for the extensions repos in the test job.
Not sure what was the reason for setting the names differently in the job parameters.

Does the test code have ability at the moment to fetch PR refs and checkout a merge ref of extensions repos

The test job takes JDK_REPO, JDK_BRANCH and OPENJDK_SHA. If the correct ref is passed in, the test job is able to get the extension repo materials.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants