Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenJDK test flag vm.opt.final.ClassUnloading should be true #18038

Closed
pshipton opened this issue Aug 29, 2023 · 4 comments
Closed

OpenJDK test flag vm.opt.final.ClassUnloading should be true #18038

pshipton opened this issue Aug 29, 2023 · 4 comments
Assignees
@babsingh
Labels
comp:test comp:vm
Milestone
Java 21 (0.42)

Comments

@pshipton
Copy link
Member

It seems vm.opt.final.ClassUnloading should be true.

It was set to false by ibmruntimes/openj9-openjdk-jdk19#34 due to a particular Hotspot centric test. However the flag should be true and the test should be excluded.

https://github.com/ibmruntimes/openj9-openjdk-jdk21/blob/openj9/closed/test/jtreg-ext/requires/OpenJ9PropsExt.java#L59
@pshipton pshipton added this to the Java 21 (0.42) milestone Aug 29, 2023
babsingh added a commit to babsingh/openj9-openjdk-jdk21 that referenced this issue Aug 29, 2023
@babsingh
Set vm.opt.final.ClassUnloading to true
da36862 
Related: eclipse-openj9/openj9#18038

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh mentioned this issue Aug 29, 2023
Merged
@babsingh
Copy link
Contributor

babsingh commented Aug 29, 2023 •
edited
Loading

@pshipton
Copy link
Member Author

I don't think there is any reason to run sanity.functional for a change that only affects openjdk testing.

babsingh added a commit to babsingh/aqa-tests that referenced this issue Aug 30, 2023
@babsingh
[JDK21] Permanently disbale RedefinePreviousVersions
7600a92 
RedefinePreviousVersions tests Hotspot specific cmd line options which
are not supported in OpenJ9:

-Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace

RedefinePreviousVersions is permanently disabled for OpenJ9 since the
above options are not supported by OpenJ9.

Related:
- eclipse-openj9/openj9#18046
- eclipse-openj9/openj9#18038
- ibmruntimes/openj9-openjdk-jdk21#34

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh mentioned this issue Aug 30, 2023
Merged
@babsingh
Copy link
Contributor

Only serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java failed in the personal builds:

serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java is not supported by OpenJ9 and will be permanently disabled. For more details, see

babsingh added a commit to babsingh/openj9-openjdk-jdk that referenced this issue Aug 30, 2023
@babsingh
Set vm.opt.final.ClassUnloading to true
7284750 
Related: eclipse-openj9/openj9#18038

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh mentioned this issue Aug 30, 2023
Merged
@babsingh
Copy link
Contributor

PRs which set vm.opt.final.ClassUnloading to true:

llxia pushed a commit to adoptium/aqa-tests that referenced this issue Aug 30, 2023
@babsingh
[JDK21] Permanently disbale RedefinePreviousVersions (#4736)
9eafbf2 
RedefinePreviousVersions tests Hotspot specific cmd line options which
are not supported in OpenJ9:

-Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace

RedefinePreviousVersions is permanently disabled for OpenJ9 since the
above options are not supported by OpenJ9.

Related:
- eclipse-openj9/openj9#18046
- eclipse-openj9/openj9#18038
- ibmruntimes/openj9-openjdk-jdk21#34

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/aqa-tests that referenced this issue Aug 30, 2023
@babsingh
[JDK22] Permanently disbale RedefinePreviousVersions
1256afd 
RedefinePreviousVersions tests Hotspot specific cmd line options which
are not supported in OpenJ9:

-Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace

RedefinePreviousVersions is permanently disabled for OpenJ9 since the
above options are not supported by OpenJ9.

Related:
- eclipse-openj9/openj9#18046
- eclipse-openj9/openj9#18038
- ibmruntimes/openj9-openjdk-jdk21#34
- adoptium#4736

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh babsingh mentioned this issue Aug 30, 2023
Merged
LongyuZhang pushed a commit to adoptium/aqa-tests that referenced this issue Aug 30, 2023
@babsingh
[JDK22] Permanently disbale RedefinePreviousVersions (#4741)
7ef2b0f 
RedefinePreviousVersions tests Hotspot specific cmd line options which
are not supported in OpenJ9:

-Xlog:redefine+class+iklass+add=trace,redefine+class+iklass+purge=trace

RedefinePreviousVersions is permanently disabled for OpenJ9 since the
above options are not supported by OpenJ9.

Related:
- eclipse-openj9/openj9#18046
- eclipse-openj9/openj9#18038
- ibmruntimes/openj9-openjdk-jdk21#34
- #4736

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babsingh babsingh

Labels
comp:test comp:vm
Projects
None yet
Milestone
Java 21 (0.42)
Development

No branches or pull requests
2 participants
@babsingh @pshipton