Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LDR_CNTRL in AIX to use 64KB page sizes. #19052

Open
6 tasks
rmnattas opened this issue Mar 1, 2024 · 8 comments
Open
6 tasks

Use LDR_CNTRL in AIX to use 64KB page sizes. #19052

rmnattas opened this issue Mar 1, 2024 · 8 comments

Comments

@rmnattas
Copy link
Contributor Author

rmnattas commented Mar 1, 2024

@pshipton @zl-wang

@pshipton
Copy link
Member

pshipton commented Mar 1, 2024

https://bugs.openjdk.org/browse/JDK-8252802 wasn't committed. The status is withdrawn, and the PR openjdk/jdk#17906 (comment) was closed due to that comment.

What testing have we done on this change locally?

@rmnattas
Copy link
Contributor Author

rmnattas commented Mar 1, 2024

Tested couple workloads locally and it may have helped somewhat or stayed the same, with not significant impact on memory usage (positive or negative), hence no significant implication. Also pLinux already uses 64KB everywhere by default.

@pshipton
Copy link
Member

pshipton commented Mar 1, 2024

That doesn't seem like a strong justification to go ahead with the change and the potential risks. Everything forked from the JVM will have the same settings.

@zl-wang
Copy link
Contributor

zl-wang commented Mar 1, 2024

In the past (java7 time), we set it anyway. It was lost without our knowing when the build was moved to Bangalore. On POWER6/7, it had substantial performance benefit. On newer processor(s), the benefit seemed less (2-3%). No other implications expected. @pshipton

@pshipton
Copy link
Member

pshipton commented Mar 1, 2024

Pls run internal builds with all the test suites.

@pshipton
Copy link
Member

pshipton commented Mar 7, 2024

Besides the testing, the change should include an option to control the behavior, so a user or dev can turn it off for diagnostics, if it's causing problems, or the change isn't desired. An example similar option is -XX:[+/-]UseZlibNX.
https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/openj9/src/java.base/unix/native/libjli/java_md.c#L390

@zl-wang
Copy link
Contributor

zl-wang commented Mar 7, 2024

that sounds reasonable. we only set it when -XX:-YYY is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants