From 003bbfc05f7eb1a73f97dec6a2c07e13aebbc01b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= Date: Mon, 11 Sep 2023 16:58:34 +0200 Subject: [PATCH] Clean Up: Add final modifier to private fields --- .../builder/tests/ApiTestingEnvironment.java | 6 +-- .../usage/UnusedApiProblemFilterTests.java | 4 +- .../model/tests/ApiDescriptionTests.java | 2 +- .../util/tests/ApiBaselineManagerTests.java | 6 +-- .../HeadlessApiBaselineManagerTests.java | 2 +- .../api/tools/ui/internal/ApiUIPlugin.java | 2 +- .../internal/CompositeApiImageDescriptor.java | 2 +- .../internal/actions/CollapseAllAction.java | 2 +- .../ui/internal/actions/ExpandAllAction.java | 2 +- .../ui/internal/actions/ExportDialog.java | 6 +-- .../ui/internal/actions/NavigateAction.java | 4 +- .../internal/actions/TreeViewerNavigator.java | 2 +- .../markers/ApiMarkerResolutionGenerator.java | 2 +- .../tools/ui/internal/markers/NodeFinder.java | 2 +- .../PDEConfigureProblemSeverityAction.java | 2 +- .../markers/UpdateSinceTagOperation.java | 6 +-- .../markers/VersionNumberingResolution.java | 2 +- .../ApiBaselinesConfigurationBlock.java | 12 ++--- .../ApiErrorsWarningsConfigurationBlock.java | 18 +++---- .../ApiUseScanConfigurationBlock.java | 8 +-- .../refactoring/CreateFileChange.java | 2 +- .../internal/use/DescriptionPatternPage.java | 2 +- .../DirectoryBasedApiBaselineWizardPage.java | 2 +- .../wizards/JavadocConversionRefactoring.java | 2 +- .../TargetBasedApiBaselineWizardPage.java | 6 +-- .../api/tools/internal/ApiAnnotations.java | 2 +- .../tools/internal/ApiDescriptionManager.java | 2 +- .../internal/ApiDescriptionProcessor.java | 4 +- .../internal/ApiDescriptionXmlCreator.java | 8 +-- .../internal/BundleListTargetLocation.java | 2 +- .../tools/internal/BundleVersionRange.java | 2 +- .../pde/api/tools/internal/CRCVisitor.java | 2 +- .../internal/CompositeApiDescription.java | 2 +- .../tools/internal/ProjectApiDescription.java | 2 +- .../RequiredComponentDescription.java | 8 +-- .../api/tools/internal/SessionManager.java | 4 +- .../api/tools/internal/TypeAnnotations.java | 4 +- .../AbstractIllegalMethodReference.java | 4 +- .../builder/AbstractIllegalTypeReference.java | 2 +- .../builder/AbstractLeakProblemDetector.java | 2 +- .../builder/AbstractProblemDetector.java | 2 +- .../internal/builder/ApiAnalysisBuilder.java | 10 ++-- .../tools/internal/builder/BuildState.java | 4 +- .../IllegalFieldReferenceDetector.java | 6 +-- .../IllegalImplementsProblemDetector.java | 2 +- .../IllegalMethodReferenceDetector.java | 2 +- .../builder/ProblemDetectorBuilder.java | 2 +- .../internal/builder/ReferenceExtractor.java | 6 +-- .../internal/builder/SinceTagChecker.java | 2 +- .../tools/internal/builder/TagValidator.java | 2 +- .../api/tools/internal/builder/TypeScope.java | 4 +- .../api/tools/internal/builder/Validator.java | 2 +- .../comparator/ClassFileComparator.java | 2 +- .../internal/comparator/DeltaXmlVisitor.java | 4 +- .../descriptors/MemberDescriptorImpl.java | 2 +- .../descriptors/MethodDescriptorImpl.java | 2 +- .../NamedElementDescriptorImpl.java | 2 +- .../api/tools/internal/model/ApiBaseline.java | 2 +- .../api/tools/internal/model/ApiField.java | 2 +- .../api/tools/internal/model/ApiMember.java | 4 +- .../api/tools/internal/model/ApiMethod.java | 2 +- .../pde/api/tools/internal/model/ApiType.java | 4 +- .../model/ArchiveApiTypeContainer.java | 2 +- .../tools/internal/model/BundleComponent.java | 6 +-- .../model/CompositeApiTypeContainer.java | 2 +- .../api/tools/internal/model/MethodKey.java | 6 +-- .../internal/model/ProjectComponent.java | 2 +- .../internal/model/ProjectTypeContainer.java | 2 +- .../internal/model/ResourceApiTypeRoot.java | 2 +- .../tools/internal/provisional/ApiPlugin.java | 2 +- .../search/ConsumerReportConvertor.java | 2 +- .../internal/search/MissingRefParser.java | 4 +- .../search/MissingRefReportConverter.java | 2 +- .../internal/search/ReferenceDescriptor.java | 18 +++---- .../search/ReferenceLookupVisitor.java | 8 +-- .../internal/search/SkippedComponent.java | 4 +- .../search/UseScanReferenceVisitor.java | 4 +- .../pde/api/tools/internal/util/TarEntry.java | 2 +- .../pde/api/tools/internal/util/TarFile.java | 2 +- .../pde/api/tools/internal/util/Util.java | 2 +- .../APIDeprecationReportConversionTask.java | 4 +- .../tasks/APIFreezeReportConversionTask.java | 6 +-- .../tools/internal/tasks/APIFreezeTask.java | 2 +- .../internal/tasks/ApiFileGenerationTask.java | 2 +- .../internal/tasks/ApiMigrationTask.java | 2 +- .../tasks/FilterListDeltaVisitor.java | 8 +-- .../internal/ds/core/builders/DSBuilder.java | 4 +- .../ds/core/text/DSDocumentFactory.java | 2 +- .../ds/core/text/DSDocumentHandler.java | 2 +- .../internal/ds/ui/editor/DSTextHover.java | 2 +- .../ds/ui/editor/FormEntryAdapter.java | 2 +- .../contentassist/DSCompletionProposal.java | 6 +-- .../DSContentAssistProcessor.java | 2 +- .../contentassist/DSContentAssistText.java | 4 +- .../TypePackageCompletionProcessor.java | 2 +- .../dialogs/DSEditPropertiesDialog.java | 4 +- .../editor/dialogs/DSEditPropertyDialog.java | 6 +-- .../editor/dialogs/DSEditProvideDialog.java | 4 +- .../editor/dialogs/DSEditReferenceDialog.java | 4 +- .../editor/sections/DSReferenceSection.java | 2 +- .../ds/ui/wizards/DSCreationOperation.java | 4 +- .../ds/ui/wizards/DSFileWizardPage.java | 2 +- .../cheatsheet/comp/CompCSModelFactory.java | 2 +- .../cheatsheet/comp/CompCSWorkspaceModel.java | 4 +- .../simple/text/SimpleCSDocumentFactory.java | 2 +- .../simple/text/SimpleCSDocumentHandler.java | 2 +- .../cheatsheet/simple/text/SimpleCSModel.java | 2 +- .../ctxhelp/text/CtxHelpDocumentFactory.java | 2 +- .../ctxhelp/text/CtxHelpDocumentHandler.java | 2 +- .../ua/core/toc/text/TocDocumentFactory.java | 2 +- .../ua/core/toc/text/TocDocumentHandler.java | 2 +- .../internal/ua/core/toc/text/TocModel.java | 2 +- .../editor/cheatsheet/CSAbstractDetails.java | 4 +- .../cheatsheet/comp/CompCSGroupValidator.java | 6 +-- .../comp/CompCSMasterTreeSection.java | 6 +-- .../ui/editor/cheatsheet/comp/CompCSPage.java | 2 +- .../details/CompCSEnclosingTextDetails.java | 4 +- .../cheatsheet/simple/NewCommandKeyEvent.java | 4 +- .../simple/SimpleCSCommandManager.java | 2 +- .../simple/SimpleCSDefinitionPage.java | 2 +- .../simple/SimpleCSMasterTreeSection.java | 10 ++-- .../simple/details/SimpleCSIntroDetails.java | 2 +- .../simple/details/SimpleCSItemDetails.java | 4 +- .../details/SimpleCSSubItemDetails.java | 2 +- .../ua/ui/editor/ctxhelp/CtxHelpPage.java | 2 +- .../details/CtxHelpAbstractDetails.java | 4 +- .../ua/ui/editor/toc/TocDragAdapter.java | 2 +- .../ua/ui/editor/toc/TocDropAdapter.java | 2 +- .../toc/TocFoldingStructureProvider.java | 2 +- .../internal/ua/ui/editor/toc/TocPage.java | 2 +- .../ua/ui/editor/toc/TocTreeSection.java | 10 ++-- .../toc/details/TocAbstractDetails.java | 4 +- .../cheatsheet/CSCategoryTrackerUtil.java | 6 +-- .../wizards/cheatsheet/RegisterCSWizard.java | 2 +- .../wizards/ctxhelp/NewCtxHelpOperation.java | 2 +- .../ctxhelp/RegisterCtxHelpOperation.java | 8 +-- .../ctxhelp/RegisterCtxHelpWizard.java | 2 +- .../ua/ui/wizards/toc/RegisterTocWizard.java | 2 +- .../ua/ui/wizards/toc/TocHTMLOperation.java | 2 +- .../ua/ui/wizards/toc/TocOperation.java | 4 +- .../RequiredPluginsClasspathContainer.java | 2 +- .../internal/core/SourceLocationManager.java | 4 +- .../ExportPackageAnnotationProcessor.java | 2 +- .../pde/internal/core/bnd/BndBuilder.java | 6 +-- .../internal/core/bnd/BndErrorReporter.java | 2 +- .../pde/internal/core/bnd/FileResource.java | 2 +- .../pde/internal/core/feature/Feature.java | 2 +- .../pde/internal/core/product/Product.java | 10 ++-- .../core/target/ExternalFileTargetHandle.java | 2 +- .../core/target/TargetPlatformService.java | 2 +- .../TargetReferenceBundleContainer.java | 2 +- .../update/configurator/Configuration.java | 4 +- .../configurator/ConfigurationParser.java | 2 +- .../update/configurator/FeatureEntry.java | 14 +++--- .../configurator/VersionedIdentifier.java | 4 +- .../tests/UpdateUnitVersionsCommandTests.java | 2 +- .../autocomplete/InstallableUnitProposal.java | 4 +- .../TargetCompletionProposal.java | 10 ++-- .../AttributeNameCompletionProcessor.java | 22 ++++---- .../AttributeValueCompletionProcessor.java | 6 +-- .../processors/TagCompletionProcessor.java | 4 +- .../TagValueCompletionProcessor.java | 6 +-- .../target/extension/model/xml/Parser.java | 12 ++--- .../extension/model/xml/XMLElement.java | 18 +++---- .../target/extension/p2/UpdateJob.java | 2 +- .../folding/FoldingReconcilerStrategy.java | 4 +- .../TargetPlatformFoldingReconciler.java | 2 +- .../presentation/GeneralTagRule.java | 2 +- .../TargetPlatformAttributeRule.java | 2 +- .../TargetPlatformPresentationReconciler.java | 4 +- .../presentation/TargetPlatformTagRule.java | 2 +- .../TargedDefinitionSetupParticipant.java | 2 +- .../junit/runtime/MultiBundleClassLoader.java | 2 +- .../junit/runtime/PlatformUITestHarness.java | 2 +- .../junit/runtime/RemotePluginTestRunner.java | 2 +- .../launching/launcher/LaunchListener.java | 2 +- .../sourcelookup/PDESourceLookupDirector.java | 2 +- .../sourcelookup/PDESourceLookupQuery.java | 4 +- .../pde/internal/runtime/OverlayIcon.java | 2 +- .../runtime/registry/RegistryBrowser.java | 4 +- .../RegistryBrowserContentProvider.java | 2 +- .../RegistryBrowserLabelProvider.java | 50 +++++++++---------- .../RegistryBrowserModelChangeListener.java | 2 +- .../registry/RegistryFilteredTree.java | 2 +- .../runtime/registry/model/Folder.java | 4 +- .../registry/model/ModelChangeDelta.java | 4 +- .../runtime/registry/model/RegistryModel.java | 14 +++--- .../runtime/registry/model/ServiceName.java | 4 +- .../internal/runtime/spy/SpyFormToolkit.java | 8 +-- .../runtime/spy/dialogs/MenuSpyDialog.java | 4 +- .../runtime/spy/dialogs/SpyDialog.java | 4 +- .../pde/spy/css/CSSPropertyProvider.java | 6 +-- .../pde/spy/css/CSSScratchPadPart.java | 2 +- .../org/eclipse/pde/spy/css/CssSpyPart.java | 4 +- .../eclipse/pde/spy/css/TextPopupDialog.java | 4 +- .../event/internal/model/ItemToFilter.java | 2 +- .../spy/event/internal/model/Operator.java | 4 +- .../event/internal/model/SpecialValue.java | 2 +- .../internal/ui/CapturedEventFilters.java | 2 +- .../event/internal/ui/CapturedEventTree.java | 4 +- .../pde/spy/event/internal/ui/ToggleLink.java | 2 +- .../pde/spy/model/MemoryModelResource.java | 4 +- .../eclipse/pde/spy/model/ModelSpyPart.java | 4 +- .../preferences/addon/PreferenceSpyAddon.java | 10 ++-- .../handler/ShowAllPreferencesHandler.java | 2 +- .../model/AbstractModelObject.java | 2 +- .../model/PreferenceEntryManager.java | 2 +- .../viewer/PreferenceMapLabelProvider.java | 2 +- .../viewer/PreferenceSpyEditingSupport.java | 2 +- .../ui/templates/PDETemplateSection.java | 2 +- .../smartimport/plugins/ImportedProject.java | 6 +-- .../smartimport/plugins/ProjectProposal.java | 2 +- .../ClasspathContainerInitializer.java | 2 +- .../pde/ui/tests/util/PDEPerfTesterUtil.java | 2 +- .../pde/ui/tests/util/ProjectUtils.java | 2 +- .../OSGiAnnotationsASTVisitor.java | 2 +- .../internal/ui/build/RuntimeInstallJob.java | 4 +- .../ui/commands/CommandComposerDialog.java | 2 +- .../internal/ui/commands/CommandDetails.java | 4 +- .../pde/internal/ui/commands/CommandList.java | 8 +-- .../commands/CommandTreeContentProvider.java | 2 +- .../pde/internal/ui/commands/TagManager.java | 4 +- .../compare/ManifestContentMergeViewer.java | 2 +- .../AddAutomaticModuleResolution.java | 2 +- .../AddSingletonToSymbolicName.java | 2 +- .../ChooseManifestClassResolution.java | 2 +- .../CreateManifestClassResolution.java | 2 +- .../java/JavaResolutionFactory.java | 4 +- .../ui/correction/java/QuickFixProcessor.java | 2 +- .../java/SearchRepositoriesForIUProposal.java | 2 +- .../java/UnresolvedImportFixProcessor.java | 2 +- .../ui/dialogs/FeatureSelectionDialog.java | 2 +- .../ui/dialogs/PluginSelectionDialog.java | 2 +- .../internal/ui/dialogs/RepositoryDialog.java | 2 +- .../AbstractFoldingStructureProvider.java | 4 +- .../internal/ui/editor/FormEntryAdapter.java | 2 +- .../internal/ui/editor/FormOutlinePage.java | 2 +- .../ui/editor/JarEntryEditorInput.java | 2 +- .../pde/internal/ui/editor/JarEntryFile.java | 4 +- .../pde/internal/ui/editor/LinkSection.java | 2 +- .../internal/ui/editor/ModelUndoManager.java | 2 +- .../internal/ui/editor/PDEDragAdapter.java | 2 +- .../internal/ui/editor/PDEDropAdapter.java | 4 +- .../ui/editor/PDEFormEditorContributor.java | 4 +- .../editor/PDEFormTextEditorContributor.java | 2 +- .../ui/editor/PDEHyperlinkDetector.java | 2 +- .../ui/editor/PDELauncherFormEditor.java | 2 +- .../ui/editor/PDEMasterDetailsBlock.java | 2 +- .../ui/editor/PDEProjectionSourcePage.java | 4 +- .../ui/editor/PDEProjectionViewer.java | 2 +- .../pde/internal/ui/editor/PDESection.java | 2 +- .../pde/internal/ui/editor/PDESourcePage.java | 2 +- .../ui/editor/PDEStorageDocumentProvider.java | 2 +- .../internal/ui/editor/SourceOutlinePage.java | 12 ++--- .../ui/editor/actions/CollapseAction.java | 4 +- .../ui/editor/actions/FormatOperation.java | 2 +- .../ui/editor/actions/SortAction.java | 4 +- .../pde/internal/ui/editor/bnd/BndModel.java | 2 +- .../editor/build/BuildClasspathSection.java | 4 +- .../editor/build/BuildHyperlinkDetector.java | 2 +- .../ui/editor/build/BuildInputContext.java | 2 +- .../build/BuildSourceViewerConfiguration.java | 2 +- .../ui/editor/build/JARFileFilter.java | 2 +- .../editor/category/CategoryInputContext.java | 2 +- .../category/CategoryLabelProvider.java | 6 +-- .../internal/ui/editor/category/IUsPage.java | 2 +- .../contentassist/TypeCompletionProposal.java | 4 +- .../contentassist/TypeContentProposal.java | 8 +-- .../TypeContentProposalProvider.java | 6 +-- .../TypeFieldAssistDisposer.java | 4 +- .../TypePackageCompletionProcessor.java | 2 +- .../contentassist/VirtualSchemaObject.java | 4 +- .../contentassist/XMLCompletionProposal.java | 6 +-- .../XMLContentAssistProcessor.java | 2 +- .../contentassist/XMLContentAssistText.java | 4 +- .../display/JavaDocCommentReader.java | 4 +- .../ui/editor/context/InputContext.java | 2 +- .../internal/ui/editor/feature/Choice.java | 4 +- .../ui/editor/feature/FeatureOutlinePage.java | 2 +- .../ui/editor/feature/InfoFormPage.java | 2 +- .../ui/editor/feature/InfoSection.java | 4 +- .../editor/feature/LicenseFeatureSection.java | 4 +- .../feature/PortabilityChoicesDialog.java | 4 +- .../feature/SynchronizeVersionsWizard.java | 2 +- .../SynchronizeVersionsWizardPage.java | 4 +- .../ui/editor/feature/URLSection.java | 2 +- .../QuickOutlineMouseMoveListener.java | 2 +- .../outline/QuickOutlinePopupDialog.java | 4 +- .../plugin/AbstractPluginElementDetails.java | 2 +- .../internal/ui/editor/plugin/BlankQuery.java | 2 +- .../BundleFoldingStructureProvider.java | 2 +- .../plugin/BundleHyperlinkDetector.java | 2 +- .../ui/editor/plugin/BundleInputContext.java | 2 +- .../plugin/CreateManifestOperation.java | 2 +- .../plugin/ExecutionEnvironmentSection.java | 2 +- .../plugin/ExtensionElementDetails.java | 4 +- .../ui/editor/plugin/ExtensionPointsPage.java | 2 +- .../ui/editor/plugin/ExtensionsPage.java | 2 +- .../editor/plugin/JarSelectionValidator.java | 4 +- .../ui/editor/plugin/JavaAttributeValue.java | 4 +- .../ui/editor/plugin/JavaAttributeWizard.java | 8 +-- .../plugin/JavaAttributeWizardPage.java | 8 +-- .../internal/ui/editor/plugin/LoopDialog.java | 4 +- .../ui/editor/plugin/ManifestSourcePage.java | 14 +++--- .../ui/editor/plugin/NewElementAction.java | 4 +- .../plugin/NewRuntimeLibraryDialog.java | 6 +-- .../PluginFoldingStructureProvider.java | 2 +- .../ui/editor/plugin/PluginInputContext.java | 2 +- .../editor/plugin/ResourceAttributeValue.java | 4 +- .../ui/editor/product/ArgumentsSection.java | 2 +- .../ui/editor/product/DependenciesPage.java | 2 +- .../ui/editor/product/LauncherSection.java | 2 +- .../editor/product/ProductExportAction.java | 4 +- .../ui/editor/product/PropertiesSection.java | 6 +-- .../product/SplashConfigurationSection.java | 8 +-- .../editor/product/WindowImagesSection.java | 2 +- .../editor/schema/AbstractSchemaDetails.java | 6 +-- .../internal/ui/editor/schema/DocSection.java | 6 +-- .../ui/editor/schema/ElementSection.java | 4 +- .../schema/ElementSectionDragAdapter.java | 2 +- .../schema/ElementSectionDropAdapter.java | 4 +- ...ilteredSchemaAttributeSelectionDialog.java | 4 +- .../editor/schema/NewClassCreationWizard.java | 2 +- .../ui/editor/schema/NewCompositorAction.java | 6 +-- .../ui/editor/schema/NewReferenceAction.java | 4 +- .../ui/editor/schema/SchemaFormPage.java | 2 +- .../ui/editor/schema/SchemaOverviewPage.java | 2 +- .../ui/editor/schema/SchemaRearranger.java | 2 +- .../internal/ui/editor/site/FeaturesPage.java | 2 +- .../ui/editor/site/NewArchiveDialog.java | 2 +- .../ui/editor/site/SiteInputContext.java | 2 +- .../ui/editor/site/SiteLabelProvider.java | 2 +- .../site/SynchronizePropertiesAction.java | 4 +- .../site/SynchronizePropertiesWizard.java | 4 +- .../site/SynchronizePropertiesWizardPage.java | 4 +- .../targetdefinition/ArgumentsSection.java | 4 +- .../targetdefinition/ContentSection.java | 2 +- .../targetdefinition/EnvironmentSection.java | 2 +- .../ImplicitDependenciesSection.java | 2 +- .../targetdefinition/InformationSection.java | 4 +- .../editor/targetdefinition/JRESection.java | 2 +- .../targetdefinition/LocationsSection.java | 2 +- .../SimpleFormEntryAdapter.java | 2 +- .../editor/targetdefinition/TargetEditor.java | 8 +-- .../ui/editor/text/AbstractHyperlink.java | 2 +- .../internal/ui/editor/text/ColorManager.java | 2 +- .../ui/editor/text/JavaHyperlink.java | 2 +- .../ui/editor/text/ManifestConfiguration.java | 6 +-- .../ui/editor/text/ManifestTextHover.java | 4 +- .../text/PDESelectAnnotationRulerAction.java | 6 +-- .../ui/editor/text/PDESourceInfoProvider.java | 2 +- .../ui/editor/text/PluginXMLTextHover.java | 2 +- .../ui/editor/text/ReconcilingStrategy.java | 2 +- .../ui/editor/text/ResourceHyperlink.java | 2 +- .../ui/editor/text/SchemaHyperlink.java | 2 +- .../text/SourceInformationProvider.java | 2 +- .../ui/editor/text/TranslationHyperlink.java | 2 +- .../editor/text/XMLReconcilingStrategy.java | 2 +- .../validation/AbstractControlValidator.java | 6 +-- .../ui/editor/validation/TextValidator.java | 2 +- .../pde/internal/ui/elements/ElementList.java | 2 +- .../internal/ui/elements/NamedElement.java | 4 +- .../ui/launcher/AbstractPluginBlock.java | 4 +- .../launcher/ApplicationSelectionDialog.java | 4 +- .../internal/ui/launcher/BlockAdapter.java | 4 +- .../internal/ui/launcher/FeatureBlock.java | 2 +- .../pde/internal/ui/launcher/JREBlock.java | 4 +- .../internal/ui/launcher/LaunchAction.java | 8 +-- .../ui/launcher/OSGiFrameworkBlock.java | 8 +-- .../internal/ui/launcher/ProgramBlock.java | 4 +- .../ui/launcher/SoftwareInstallBlock.java | 2 +- .../internal/ui/launcher/TracingBlock.java | 6 +-- .../ui/launcher/TracingPropertySource.java | 16 +++--- .../nls/ExternalizeStringsLabelProvider.java | 2 +- .../ui/nls/ExternalizeStringsOperation.java | 8 +-- .../ui/nls/ExternalizeStringsWizard.java | 2 +- .../GetNonExternalizedStringsOperation.java | 4 +- .../ui/nls/InternationalizeModelTable.java | 4 +- .../ui/nls/InternationalizeOperation.java | 2 +- .../ui/nls/InternationalizeWizard.java | 2 +- .../nls/InternationalizeWizardLocalePage.java | 4 +- .../InternationalizeWizardOpenOperation.java | 2 +- .../nls/InternationalizeWizardPluginPage.java | 2 +- .../pde/internal/ui/nls/ModelChange.java | 4 +- .../internal/ui/nls/ModelChangeElement.java | 4 +- .../pde/internal/ui/nls/ModelChangeFile.java | 6 +-- .../ui/nls/ModelChangeLabelProvider.java | 4 +- .../pde/internal/ui/nls/ModelChangeTable.java | 4 +- .../internal/ui/nls/NLSFragmentGenerator.java | 2 +- .../parts/ConditionalListSelectionDialog.java | 2 +- .../pde/internal/ui/parts/MessageLine.java | 2 +- .../internal/ui/parts/PDESourceViewer.java | 4 +- .../internal/ui/parts/PluginVersionPart.java | 2 +- .../ui/parts/SharedPartWithButtons.java | 2 +- .../ui/parts/WizardCheckboxTablePart.java | 2 +- .../ui/parts/WizardCheckboxTreePart.java | 2 +- .../ui/preferences/AddToJavaSearchJob.java | 2 +- .../pde/internal/ui/preferences/BuildJob.java | 2 +- .../ui/preferences/EditorPreferencePage.java | 2 +- .../PDECompilersConfigurationBlock.java | 20 ++++---- .../ui/preferences/SyntaxColorTab.java | 4 +- .../TargetPlatformPreferencePage.java | 6 +-- .../properties/SelfHostingPropertyPage.java | 2 +- .../CreateHeaderChangeOperation.java | 8 +-- .../refactoring/FindReferenceOperation.java | 4 +- .../ui/refactoring/MovedTextFileChange.java | 2 +- .../ui/search/FindDeclarationsAction.java | 2 +- .../ui/search/FindReferencesAction.java | 4 +- .../internal/ui/search/PluginSearchPage.java | 6 +-- .../internal/ui/search/PluginSearchQuery.java | 2 +- .../AddNewDependenciesAction.java | 4 +- .../dependencies/CalculateUsesAction.java | 4 +- .../dependencies/CalculateUsesOperation.java | 4 +- .../dependencies/DependencyExtentAction.java | 4 +- .../DependencyExtentOperation.java | 8 +-- .../dependencies/DependencyExtentQuery.java | 4 +- .../GatherUnusedDependenciesOperation.java | 2 +- .../dependencies/ShowResultsAction.java | 4 +- .../UnusedDependenciesAction.java | 4 +- .../dependencies/UnusedDependenciesJob.java | 4 +- .../dependencies/UnusedImportsDialog.java | 6 +-- .../dialogs/FilteredIUSelectionDialog.java | 2 +- ...ilteredPluginArtifactsSelectionDialog.java | 24 ++++----- .../AddBundleContainerSelectionPage.java | 8 +-- .../target/AddBundleContainerWizard.java | 2 +- ...ArgumentsFromContainerSelectionDialog.java | 2 +- .../ui/shared/target/CopyLocationAction.java | 2 +- .../target/CopyTreeSelectionAction.java | 2 +- .../target/EditBundleContainerWizard.java | 4 +- .../ui/shared/target/EditIUContainerPage.java | 4 +- .../target/EditTargetContainerPage.java | 2 +- .../ui/shared/target/IUContentProvider.java | 4 +- .../shared/target/PreviewContainerPage.java | 4 +- .../target/SelectRepositoryContentPage.java | 4 +- .../target/StyledBundleLabelProvider.java | 2 +- .../ui/shared/target/TargetBundleAdapter.java | 2 +- .../ui/shared/target/TargetContentsGroup.java | 4 +- .../shared/target/TargetFeatureAdapter.java | 2 +- .../shared/target/TargetLocationsGroup.java | 4 +- ...eferenceBundleContainerAdapterFactory.java | 2 +- .../shared/target/ToggleIncludeHandler.java | 8 +-- .../ui/shared/target/UpdateTargetJob.java | 2 +- .../internal/ui/util/AbstractOverlayIcon.java | 2 +- .../ui/util/AcceleratedTreeScrolling.java | 4 +- .../ui/util/ChoicePropertyDescriptor.java | 2 +- .../internal/ui/util/FileExtensionFilter.java | 2 +- .../ui/util/FileExtensionsFilter.java | 2 +- .../pde/internal/ui/util/FileNameFilter.java | 2 +- .../internal/ui/util/ImageOverlayIcon.java | 2 +- .../ui/util/TemplateFileGenerator.java | 12 ++--- .../DependenciesLabelProvider.java | 4 +- .../views/dependencies/DependenciesView.java | 8 +-- .../dependencies/DependenciesViewPage.java | 6 +-- .../DependenciesViewPageContentProvider.java | 2 +- .../DependenciesViewTreePage.java | 2 +- .../ui/views/dependencies/HistoryAction.java | 6 +-- .../dependencies/HistoryDropDownAction.java | 2 +- .../views/dependencies/HistoryListAction.java | 2 +- .../views/dependencies/HistoryListDialog.java | 2 +- .../OpenPluginReferencesAction.java | 2 +- .../views/imagebrowser/ImageBrowserView.java | 2 +- .../repositories/AbstractRepository.java | 2 +- .../TargetPlatformRepository.java | 2 +- .../views/plugins/JavaSearchActionGroup.java | 2 +- .../ui/views/plugins/JavaSearchOperation.java | 4 +- .../views/plugins/PluginsContentProvider.java | 4 +- .../views/plugins/PluginsLabelProvider.java | 6 +-- .../ui/views/plugins/PluginsView.java | 10 ++-- .../ui/views/target/StateViewPage.java | 12 ++--- .../ui/views/target/TargetStateView.java | 4 +- .../ui/wizards/BaseWizardSelectionPage.java | 4 +- .../pde/internal/ui/wizards/Category.java | 2 +- .../pde/internal/ui/wizards/RenameDialog.java | 2 +- .../wizards/RequiredPluginsContainerPage.java | 6 +-- .../wizards/WizardCollectionComparator.java | 2 +- .../ui/wizards/WizardListSelectionPage.java | 2 +- .../pde/internal/ui/wizards/WizardNode.java | 2 +- .../ui/wizards/WizardTreeSelectionPage.java | 4 +- .../NewCategoryCreationOperation.java | 2 +- .../exports/AntGeneratingExportWizard.java | 2 +- .../wizards/exports/BaseExportWizardPage.java | 2 +- .../exports/CrossPlatformExportPage.java | 4 +- .../ui/wizards/exports/JARSigningTab.java | 2 +- .../internal/ui/wizards/exports/JNLPTab.java | 2 +- .../exports/ProductConfigurationSection.java | 2 +- .../wizards/exports/ProductExportWizard.java | 2 +- .../exports/ProductExportWizardPage.java | 2 +- .../extension/ExtensionEditorWizard.java | 6 +-- .../extension/NewExtensionPointMainPage.java | 4 +- .../extension/NewExtensionPointWizard.java | 6 +-- .../extension/NewExtensionRegistryReader.java | 2 +- .../wizards/extension/NewExtensionWizard.java | 6 +-- .../extension/NewSchemaFileMainPage.java | 4 +- .../extension/NewSchemaFileWizard.java | 4 +- .../wizards/extension/PointSelectionPage.java | 14 +++--- .../AbstractCreateFeatureOperation.java | 2 +- .../feature/CreateFeaturePatchOperation.java | 2 +- ...eateFeatureProjectFromLaunchOperation.java | 2 +- .../imports/AlternateSourceLocations.java | 4 +- .../imports/FeatureImportOperation.java | 10 ++-- .../wizards/imports/FeatureImportWizard.java | 2 +- .../OverwriteProjectsSelectionDialog.java | 2 +- .../imports/PluginImportOperation.java | 12 ++--- .../PluginImportWizardDetailedPage.java | 4 +- .../PluginImportWizardExpressPage.java | 2 +- .../imports/PluginImportWizardFirstPage.java | 4 +- .../imports/RepositoryImportWizard.java | 4 +- .../wizards/plugin/FragmentContentPage.java | 2 +- .../plugin/NewFragmentProjectWizard.java | 2 +- .../NewLibraryPluginCreationOperation.java | 2 +- .../plugin/NewLibraryPluginCreationPage.java | 4 +- ...NewLibraryPluginCreationUpdateRefPage.java | 4 +- .../plugin/NewLibraryPluginProjectWizard.java | 6 +-- .../plugin/NewPluginProjectWizard.java | 2 +- .../NewProjectCreationFromTemplatePage.java | 2 +- .../plugin/NewProjectCreationOperation.java | 6 +-- .../plugin/NewProjectCreationPage.java | 6 +-- .../plugin/PluginClassCodeGenerator.java | 6 +-- .../plugin/PluginContentFromTemplatePage.java | 2 +- .../ui/wizards/plugin/PluginContentPage.java | 2 +- .../ui/wizards/plugin/PluginFieldData.java | 2 +- .../plugin/TemplateListSelectionPage.java | 2 +- .../product/BaseManifestOperation.java | 2 +- .../product/BaseProductCreationOperation.java | 2 +- .../product/ProductDefinitionOperation.java | 6 +-- .../product/ProductDefinitionWizard.java | 2 +- .../product/ProductDefinitonWizardPage.java | 4 +- .../product/ProductFromConfigOperation.java | 2 +- .../ProductFromExtensionOperation.java | 2 +- .../product/ProductIntroOperation.java | 4 +- .../wizards/product/ProductIntroWizard.java | 4 +- .../product/ProductIntroWizardPage.java | 6 +-- .../site/NewSiteProjectCreationOperation.java | 8 +-- .../ui/wizards/target/TargetCreationPage.java | 2 +- .../ui/wizards/templates/ControlStack.java | 4 +- .../templates/NewExtensionTemplateWizard.java | 2 +- .../wizards/templates/PreprocessorParser.java | 2 +- .../templates/TemplateSelectionPage.java | 2 +- .../ConvertProjectToPluginOperation.java | 4 +- .../wizards/tools/ConvertedProjectWizard.java | 4 +- .../wizards/tools/ConvertedProjectsPage.java | 4 +- .../tools/OrganizeManifestsWizardPage.java | 2 +- .../wizards/tools/UpdateBuildpathWizard.java | 4 +- .../tools/UpdateBuildpathWizardPage.java | 6 +-- .../eclipse/pde/ui/launcher/BundlesTab.java | 4 +- .../pde/ui/launcher/ConfigurationTab.java | 10 ++-- .../org/eclipse/pde/ui/launcher/MainTab.java | 2 +- .../pde/ui/launcher/OSGiSettingsTab.java | 6 +-- .../eclipse/pde/ui/launcher/PluginsTab.java | 6 +-- .../eclipse/pde/ui/launcher/TracingTab.java | 4 +- .../templates/BaseOptionTemplateSection.java | 2 +- .../eclipse/pde/ui/templates/BlankField.java | 2 +- .../pde/ui/templates/ChoiceOption.java | 2 +- .../NewPluginProjectFromTemplateWizard.java | 2 +- .../ui/templates/NewPluginTemplateWizard.java | 2 +- .../ui/templates/OptionTemplateSection.java | 2 +- .../templates/OptionTemplateWizardPage.java | 6 +-- .../pde/ui/templates/TemplateField.java | 2 +- .../internal/ui/samples/ProjectNamesPage.java | 2 +- .../pde/internal/ui/samples/ReviewPage.java | 2 +- .../pde/internal/ui/samples/SampleEditor.java | 2 +- .../internal/ui/samples/SampleOperation.java | 6 +-- .../ui/samples/SampleStandbyContent.java | 2 +- .../pde/internal/ui/samples/SampleWizard.java | 6 +-- .../internal/ui/samples/SelectionPage.java | 6 +-- .../internal/ui/samples/ShowSampleAction.java | 2 +- ...UnitPluginLaunchConfigurationDelegate.java | 2 +- .../spy/internal/dialogs/ControlSelector.java | 12 ++--- .../spy/internal/dialogs/LayoutSpyDialog.java | 4 +- .../LayoutIssuesDebugFilter.java | 4 +- .../TracingComponentColumnEditingSupport.java | 2 +- .../TracingComponentColumnLabelProvider.java | 2 +- 572 files changed, 1080 insertions(+), 1080 deletions(-) diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/ApiTestingEnvironment.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/ApiTestingEnvironment.java index ea921d02c6..8694441a47 100644 --- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/ApiTestingEnvironment.java +++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/ApiTestingEnvironment.java @@ -75,9 +75,9 @@ public class ApiTestingEnvironment extends TestingEnvironment { * Modified files for each build so that we can undo the changes * incrementally rather than recreating the workspace for each test. */ - private List fAdded = new ArrayList<>(); - private List fChanged = new ArrayList<>(); - private List fRemoved = new ArrayList<>(); + private final List fAdded = new ArrayList<>(); + private final List fChanged = new ArrayList<>(); + private final List fRemoved = new ArrayList<>(); public ApiTestingEnvironment() throws Exception { super(); diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/usage/UnusedApiProblemFilterTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/usage/UnusedApiProblemFilterTests.java index 1619bb6420..d4d584f4e7 100644 --- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/usage/UnusedApiProblemFilterTests.java +++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/builder/tests/usage/UnusedApiProblemFilterTests.java @@ -41,8 +41,8 @@ public class UnusedApiProblemFilterTests extends UsageTest { private static final String BEFORE = "before"; //$NON-NLS-1$ private static final String AFTER = "after"; //$NON-NLS-1$ - private IPath fRootPath = super.getTestSourcePath().append("filters"); //$NON-NLS-1$ - private IPath fFiltersPath = IPath.fromOSString("/usagetests/.settings/.api_filters"); //$NON-NLS-1$ + private final IPath fRootPath = super.getTestSourcePath().append("filters"); //$NON-NLS-1$ + private final IPath fFiltersPath = IPath.fromOSString("/usagetests/.settings/.api_filters"); //$NON-NLS-1$ public UnusedApiProblemFilterTests(String name) { super(name); diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java index 2c3ff64748..8a31d2c225 100644 --- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java +++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/model/tests/ApiDescriptionTests.java @@ -57,7 +57,7 @@ */ public class ApiDescriptionTests { - private IApiDescription fManifest = buildManifest(); + private final IApiDescription fManifest = buildManifest(); /** * Wraps an element with its API description diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java index bc3c1ce9dd..9aabd14557 100644 --- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java +++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/ApiBaselineManagerTests.java @@ -178,9 +178,9 @@ private void updateTag(BodyDeclaration body) { } } - private IPath SRC_LOC = TestSuiteHelper.getPluginDirectoryPath().append("test-source").append("a").append("b").append("c"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ - private IPath PLUGIN_LOC = TestSuiteHelper.getPluginDirectoryPath().append("test-plugins"); //$NON-NLS-1$ - private IApiBaselineManager fPMmanager = ApiPlugin.getDefault().getApiBaselineManager(); + private final IPath SRC_LOC = TestSuiteHelper.getPluginDirectoryPath().append("test-source").append("a").append("b").append("c"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ + private final IPath PLUGIN_LOC = TestSuiteHelper.getPluginDirectoryPath().append("test-plugins"); //$NON-NLS-1$ + private final IApiBaselineManager fPMmanager = ApiPlugin.getDefault().getApiBaselineManager(); private final String TESTING_PACKAGE = "a.b.c"; //$NON-NLS-1$ /** diff --git a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/HeadlessApiBaselineManagerTests.java b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/HeadlessApiBaselineManagerTests.java index 8565671b95..e9142fc0b0 100644 --- a/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/HeadlessApiBaselineManagerTests.java +++ b/apitools/org.eclipse.pde.api.tools.tests/src/org/eclipse/pde/api/tools/util/tests/HeadlessApiBaselineManagerTests.java @@ -34,7 +34,7 @@ */ public class HeadlessApiBaselineManagerTests extends AbstractApiTest { - private ApiBaselineManager fManager = ApiBaselineManager.getManager(); + private final ApiBaselineManager fManager = ApiBaselineManager.getManager(); @Override @After diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java index 65fa711eca..4874ce1307 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java @@ -235,7 +235,7 @@ public static IStatus newErrorStatus(String message, Throwable exception) { return Status.error(message, exception); } - private ISessionListener sessionListener = new ISessionListener() { + private final ISessionListener sessionListener = new ISessionListener() { @Override public void sessionAdded(ISession addedSession) { Display.getDefault().asyncExec(() -> showAPIToolingView()); diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/CompositeApiImageDescriptor.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/CompositeApiImageDescriptor.java index 09d304a471..035ce32cd2 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/CompositeApiImageDescriptor.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/CompositeApiImageDescriptor.java @@ -31,7 +31,7 @@ public class CompositeApiImageDescriptor extends CompositeImageDescriptor { public static final int WARNING = 0x0002; private Image fOriginalImage = null; - private int fFlags; + private final int fFlags; private Point fSize; /** diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/CollapseAllAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/CollapseAllAction.java index 75f6b1b5fa..15a5f6dcc0 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/CollapseAllAction.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/CollapseAllAction.java @@ -24,7 +24,7 @@ */ public class CollapseAllAction extends Action { - private TreeViewer fViewer; + private final TreeViewer fViewer; public CollapseAllAction(TreeViewer viewer) { setText(ActionMessages.CollapseAllAction_label); diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java index 5293841815..a1b440cf54 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java @@ -24,7 +24,7 @@ */ public class ExpandAllAction extends Action { - private TreeViewer fViewer; + private final TreeViewer fViewer; public ExpandAllAction(TreeViewer viewer) { setText(ActionMessages.ExpandAllAction_label); diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportDialog.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportDialog.java index 820d630d98..39b80da768 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportDialog.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportDialog.java @@ -53,12 +53,12 @@ public class ExportDialog extends Dialog { /** * The title of the dialog. */ - private String title; + private final String title; /** * The message to display, or null if none. */ - private String message; + private final String message; /** * The input value; the empty string by default. @@ -68,7 +68,7 @@ public class ExportDialog extends Dialog { /** * The input validator, or null if none. */ - private IInputValidator validator; + private final IInputValidator validator; /** * Ok button widget. diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java index 8b6f823655..901e81ac6c 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java @@ -28,8 +28,8 @@ */ public class NavigateAction extends Action { private final boolean next; - private IViewSite site; - private TreeViewer viewer; + private final IViewSite site; + private final TreeViewer viewer; public NavigateAction(APIToolingView view, boolean next) { this.site = view.getViewSite(); diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/TreeViewerNavigator.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/TreeViewerNavigator.java index f2186bb2b5..775735c363 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/TreeViewerNavigator.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/TreeViewerNavigator.java @@ -24,7 +24,7 @@ * Navigation in the tree viewer. */ class TreeViewerNavigator { - private TreeViewer fViewer; + private final TreeViewer fViewer; public TreeViewerNavigator(TreeViewer viewer) { fViewer = viewer; diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/ApiMarkerResolutionGenerator.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/ApiMarkerResolutionGenerator.java index 7423744a0a..7360be5037 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/ApiMarkerResolutionGenerator.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/ApiMarkerResolutionGenerator.java @@ -47,7 +47,7 @@ public class ApiMarkerResolutionGenerator implements IMarkerResolutionGenerator2 */ private final IMarkerResolution[] NO_RESOLUTIONS = new IMarkerResolution[0]; - private DefaultApiProfileResolution profileResolution = new DefaultApiProfileResolution(); + private final DefaultApiProfileResolution profileResolution = new DefaultApiProfileResolution(); @Override public IMarkerResolution[] getResolutions(IMarker marker) { diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/NodeFinder.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/NodeFinder.java index 58cf8c4ff3..3bcce03cd6 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/NodeFinder.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/NodeFinder.java @@ -36,7 +36,7 @@ public class NodeFinder extends ASTVisitor { private BodyDeclaration declaration; - private int position; + private final int position; /** * Constructor diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/PDEConfigureProblemSeverityAction.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/PDEConfigureProblemSeverityAction.java index 2354bcafdf..011413fb7c 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/PDEConfigureProblemSeverityAction.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/PDEConfigureProblemSeverityAction.java @@ -43,7 +43,7 @@ public class PDEConfigureProblemSeverityAction extends Action { private final String fOptionId; - private int tab; + private final int tab; public PDEConfigureProblemSeverityAction(IJavaProject project, String optionId, int t) { diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateSinceTagOperation.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateSinceTagOperation.java index 1a1a20da00..52268d1c12 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateSinceTagOperation.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/UpdateSinceTagOperation.java @@ -43,10 +43,10 @@ public class UpdateSinceTagOperation { - private IMarker fMarker; + private final IMarker fMarker; private IMarker[] otherIMarkers; - private int sinceTagType; - private String sinceTagVersion; + private final int sinceTagType; + private final String sinceTagVersion; public UpdateSinceTagOperation(IMarker marker, IMarker[] otherMarkers, int sinceTagType, String sinceTagVersion) { this.fMarker = marker; diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/VersionNumberingResolution.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/VersionNumberingResolution.java index 308c38a615..0be3cccbb4 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/VersionNumberingResolution.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/markers/VersionNumberingResolution.java @@ -35,7 +35,7 @@ public class VersionNumberingResolution implements IMarkerResolution2 { String newVersionValue; // major or minor version - private int kind; + private final int kind; private String description; public VersionNumberingResolution(IMarker marker) { diff --git a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiBaselinesConfigurationBlock.java b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiBaselinesConfigurationBlock.java index b0f24b27a2..5674b96132 100644 --- a/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiBaselinesConfigurationBlock.java +++ b/apitools/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/preferences/ApiBaselinesConfigurationBlock.java @@ -66,7 +66,7 @@ public class ApiBaselinesConfigurationBlock extends ConfigurationBlock { */ protected static class ControlData { Key key; - private String[] values; + private final String[] values; /** * Constructor @@ -110,8 +110,8 @@ public int getSelection(String value) { */ protected static class Key { - private String qualifier; - private String key; + private final String qualifier; + private final String key; /** * Constructor @@ -237,7 +237,7 @@ protected final static Key getApiToolsKey(String key) { /** * Default selection listener for controls on the page */ - private SelectionListener selectionlistener = new SelectionAdapter() { + private final SelectionListener selectionlistener = new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { if (e.widget instanceof Combo) { @@ -254,11 +254,11 @@ public void widgetSelected(SelectionEvent e) { * Listing of all of the {@link Combo}s added to the block */ - private ArrayList fCombos = new ArrayList<>(); + private final ArrayList fCombos = new ArrayList<>(); /** * Listing of the label in the block */ - private ArrayList