From dc480edb115d55e65c8c8b28f070a1d3e848c9fd Mon Sep 17 00:00:00 2001 From: Ed Merks Date: Mon, 13 Nov 2023 12:34:21 +0100 Subject: [PATCH] FeatureErrorReporter.validatePluginExists should recognized fragments The validator currently produces an error when it find the referenced plugin but the plugin is a fragment. This is wrong behavior for the latest implementation that makes no distinction between plugins versus fragments. https://github.com/eclipse-pde/eclipse.pde/issues/915 --- .../pde/internal/core/builders/FeatureErrorReporter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureErrorReporter.java b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureErrorReporter.java index a5ee71e591..23526c7757 100644 --- a/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureErrorReporter.java +++ b/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/builders/FeatureErrorReporter.java @@ -408,7 +408,7 @@ private void validatePluginExists(Element element, Attr attr) { int severity = CompilerFlags.getFlag(fProject, CompilerFlags.F_UNRESOLVED_PLUGINS); if (severity != CompilerFlags.IGNORE) { IPluginModelBase model = PluginRegistry.findModel(id); - if (model == null || !model.isEnabled() || model.isFragmentModel()) { + if (model == null || !model.isEnabled()) { VirtualMarker marker = report(NLS.bind(PDECoreMessages.Builders_Feature_reference, id), getLine(element, attr.getName()), severity, PDEMarkerFactory.CAT_OTHER); addMarkerAttribute(marker, PDEMarkerFactory.compilerKey, CompilerFlags.F_UNRESOLVED_PLUGINS); }