Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entries for Import-Package get a version range which breaks semantic versioning #1297

Closed
mwgmnn opened this issue Jun 12, 2024 · 5 comments

Comments

@mwgmnn
Copy link

mwgmnn commented Jun 12, 2024

This is a result of issue #401, which solves more that was initially asked (strip micro version). It's ok from my point of view to add an upper version limit. But i suggest to exclude the next major version by replacing the ] by a ) in the returning version range to properly follow semantic versioning.

@laeubi
Copy link
Contributor

laeubi commented Jun 12, 2024

@mwgmnn what version do you use? I think this was already fixed by @HannesWell recently.

@mwgmnn
Copy link
Author

mwgmnn commented Jun 12, 2024

@mwgmnn what version do you use? I think this was already fixed by @HannesWell recently.

It's Version 2024-03 (4.31.0), Build id: 20240307-1437.

Ok, sorry, i missed the pull request #1007. The actual code looks fine, so looking forward to the next eclipse version release.

https://github.com/eclipse-pde/eclipse.pde/blob/master/ui/org.eclipse.pde.core/text/org/eclipse/pde/internal/core/text/bundle/ImportPackageObject.java

@mwgmnn mwgmnn closed this as completed Jun 12, 2024
@merks
Copy link
Contributor

merks commented Jun 12, 2024

FYI, the 2024-06 / 4.32 release is now available.

@mwgmnn
Copy link
Author

mwgmnn commented Jun 12, 2024

Yes, great timing, thanks a lot.

@HannesWell
Copy link
Member

@mwgmnn what version do you use? I think this was already fixed by @HannesWell recently.

All said is correct, but for the record: This was fixed with #1212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants