Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native support for Eclipse SDKs on riscv64 #2310

Closed
31 of 33 tasks
yuzibo opened this issue Sep 4, 2024 · 19 comments
Closed
31 of 33 tasks

Native support for Eclipse SDKs on riscv64 #2310

yuzibo opened this issue Sep 4, 2024 · 19 comments
Labels
enhancement New feature or request

Comments

@yuzibo
Copy link

yuzibo commented Sep 4, 2024

I am trying to build Eclipse SDKs on riscv64. It's obvious that this is the correct repo so I opened the issue to keep track of various tasks done and/or underway like WoA did.

Next I will always update this.

@Sakura286
Copy link

On Debian Sid riscv64, Milk-V Pioneer.
1510c05927436e18546f7e2c4f4015b

@yuzibo
Copy link
Author

yuzibo commented Sep 27, 2024

That is amazing!

@HannesWell
Copy link
Member

Since the latest I-build the Eclipse SDK is also build for linux.riscv64

Implementation-wise almost everything is done now, the last pending two PRs should succeed now too.

The only thing that are missing to complete this entirely are some form of tests, at least smoke tests, ideally full I-build tests (for Windows on ARM they are still pending since some preparatory work to simplify their setup is not yet completed).

Furthermore we could/should provide the Eclipse-Packages for linux.riscv64 too, similar to WoA:

But unlike WoA since shouldn't be too difficult since Temurin already provides JDKs for linux.riscv64 and JustJ is now able to provide JDK bundles since there is also a Eclipse-SDK for it.

@Sakura286
Copy link

Test with the newest official Integration Build, on Debian Sid riscv64, Milk-V Pioneer, with x11 forward:

image

https://download.eclipse.org/eclipse/downloads/drops4/I20240929-0810/

Choose Eclipse SDK -> Linux (64 bit version for RISC-V) to download.

@yuzibo
Copy link
Author

yuzibo commented Sep 29, 2024

Since the latest I-build the Eclipse SDK is also build for linux.riscv64

I would like to express my heartfelt gratitude to everyone for your efforts in achieving Eclipse support for riscv64 here. Your hard work and help are truly appreciated!

The only thing that are missing to complete this entirely are some form of tests, at least smoke tests, ideally full I-build tests (for Windows on ARM they are still pending since some preparatory work to simplify their setup is not yet completed).

Furthermore we could/should provide the Eclipse-Packages for linux.riscv64 too, similar to WoA:

Okay, no problem, I will add these into the todo list also.

But unlike WoA since shouldn't be too difficult since Temurin already provides JDKs for linux.riscv64 and JustJ is now able to provide JDK bundles since there is also a Eclipse-SDK for it.

Yeah, I noticed this also. I will ping JustJ first.

Thanks for all again!

@HannesWell
Copy link
Member

Since the latest I-build the Eclipse SDK is also build for linux.riscv64

I would like to express my heartfelt gratitude to everyone for your efforts in achieving Eclipse support for riscv64 here. Your hard work and help are truly appreciated!

Thank you for these nice words, it's great to get them.
And thanks for all your contributions.
I think adding support for more arches challenges the complexity of the overall Eclipse SDK project and helps to reduce it.

But unlike WoA since shouldn't be too difficult since Temurin already provides JDKs for linux.riscv64 and JustJ is now able to provide JDK bundles since there is also a Eclipse-SDK for it.

Yeah, I noticed this also. I will ping JustJ first.

@merks is already aware of the need for a change in JustJ and has already prepared it:

and is currently working on providing the new artifacts.

@merks
Copy link
Contributor

merks commented Oct 2, 2024

@yuzibo

There is an installer with an embedded JustJ JRE available for rsicv64:

https://download.eclipse.org/oomph/products/latest/eclipse-inst-jre-linux-riscv64.tar.gz

The installer filters products that don't support that architecture (and I've been fine-tuning that support today), so it only shows applicable products, i.e., only the Eclipse SDK can currently be installed:

image

It would be much appreciated if you could test whether the riscv64 installer works given I have no way of testing it myself.

@yuzibo
Copy link
Author

yuzibo commented Oct 2, 2024

@yuzibo

There is an installer with an embedded JustJ JRE available for rsicv64:

https://download.eclipse.org/oomph/products/latest/eclipse-inst-jre-linux-riscv64.tar.gz

\o/.

It would be much appreciated if you could test whether the riscv64 installer works given I have no way of testing it myself.

Okay, No problem, I will test it on my local riscv64 hardware ASAP(maybe in next days because I am on my holiday).

Thanks for your work again!

@yuzibo
Copy link
Author

yuzibo commented Oct 8, 2024

@yuzibo

There is an installer with an embedded JustJ JRE available for rsicv64:

https://download.eclipse.org/oomph/products/latest/eclipse-inst-jre-linux-riscv64.tar.gz

if i didn't do anything wrong, I think the eclipse installer is working:
in-pocess
launch

Thanks for your work again!

@yuzibo
Copy link
Author

yuzibo commented Oct 8, 2024

So the left work for riscv64 on Eclipse is to use justj to replace temurin I think.

But I am not sure how long this will happened to update the link of downloading of justj

@merks
Copy link
Contributor

merks commented Oct 8, 2024

As mentioned in eclipse-packaging/packages#213 (comment) mostly everything is in place to produce riscv64 packages for M2.

It will appears here:

https://www.eclipse.org/downloads/packages/release/2024-12/

@sratz
Copy link
Member

sratz commented Oct 21, 2024

The riscv-build2 node on Jenkins currently fails to launch, blocking building of SWT native fragments: https://ci.eclipse.org/releng/computer/riscv%2Dbuild2/

@merks
Copy link
Contributor

merks commented Oct 21, 2024

FYI, I just started a build just minutes ago for Java 24 beta:

https://ci.eclipse.org/justj/job/build-jres/

I think this node is shared:

https://ci.eclipse.org/justj/computer/riscv%2Dbuild2/

@merks
Copy link
Contributor

merks commented Oct 21, 2024

For what it's worth, the riscv node did start and complete:

image

@jonahgraham
Copy link
Contributor

The 2024-12 M2 EPP build that contains riscv64 Linux packages is now available for testing. If you have access to riscv64 Linux, please let me know if these new packages work. See announcement in https://www.eclipse.org/lists/epp-dev/msg06939.html

@akurtakov
Copy link
Member

Should we close this one?

@jonahgraham
Copy link
Contributor

Should we close this one?

Yes, 2024-12 has full riscv in EPP too. Same as your comment on WoA (#577 (comment)), new dedicated issues should be created. I have created #2632 for the unchecked item in the list.

@yuzibo
Copy link
Author

yuzibo commented Dec 5, 2024

Thanks!
I think we can close it also as we have done everything almost already and I will track the #2632

HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this issue Dec 6, 2024
@HannesWell
Copy link
Member

Thank you @yuzibo for all your work to make this possible.

As the very final step I have now created a change to add a smoke-test for linux.riscv64:

HannesWell added a commit that referenced this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants