-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lucene to version 10 #2654
Comments
As per https://lists.apache.org/thread/4bhnkkvvodxxgrpj4yqm5yrgj0ppc59r version 9.12.0 shipped with 4.34 is the last minor 9.x version with only security releases aka 9.12.x to be done from 9.x stream. It's time to start preparing the update to 10.x as that would require a lot of changes in releng due to Java 21 requirement. |
FYI, one strange thing I get is this failure:
I can make that dependency optional, on the assumption that it really is optional. It's apparent used by this package:
I can't find much detail about that. Looking at https://lucene.apache.org/core/corenews.html I see it mentioned here: Given one needs to take explicit action to enable incubator modules and given they are documented to be definitely removed in the future, assuming it's optional seems reasonably safe... |
- Update all the poms to use JavaSE-21 because lucene 10 requires that. - Update lucene 9.x to 9.12.1 eclipse-platform/eclipse.platform.releng.aggregator#2654
Its worth a try, I just want to mention that with Multi_Release jars one can target specific JDK releases to use such features in a safe way and have it still being mandatory. But I haven't checked the details. |
In my Oomph environment I end up resolving a target platform using the orbit aggregation nightly so ended up with a combination of lucene 9 and 10 and then ended up with a mylyn wiring disaster trying to launch an IDE. It's a bit worrisome. 😱 |
what should I know? |
This is how the launch fails:
But I didn't have time to investigate further. 😞 It does seem to hint that we probably need to avoid having two major versions of lucene installed into the same IDE... |
Please share your plan @merks |
There are two lucene 10 bundles not yet approved: https://ci.eclipse.org/orbit/job/orbit-simrel-maven-bnd/249/ The nightly builds already contain them: https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/table.html The generator now provide details about the required execution environment of each bundle... A quick scan of dependencies on lucene indicate that datatools, dltk, mylyn (task) and eclipse.help have dependencies. All but mylyn have an upper bound that excludes 10.x. I'd like to experiment to determine if bounds like (9.x,11) work, i.e., if either 9.x or 10.x work for these things. I was planning on experimenting with the Platform first. I suggest you wait a little while before you dive in; maybe the problem will go away when the platform can work with 10.x. |
Thank you @merks for detailed explanation, please ping (tag) me with results of your investigations. |
New major Lucene version is out with claimed significant speed ups https://www.elastic.co/search-labs/blog/apache-lucene-10-release-highlights
The text was updated successfully, but these errors were encountered: