-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hang expanding a styled tree widget #680
Comments
The code seem to run some Windows specific text/font related calculations, I wonder if you have some element with "special" label in your tree that causes this hang. If you could nail it down, would be helpful. @SyntevoAlex : this seem not be a recent regression, but might be you have a better idea what could cause the code in question to hang? |
It’s expanding a collapsed item in a search view right after a search. |
Sure, but is this something you can reproduce in a fresh workspace and minimal search example? |
Is there a reasonable number of elements, or millions of them? |
Less than 20. It’s really seems stuck on the one child in this case. I saw this in the repo explorer the other day in a debug launch and will try that tomorrow. In this case too it was a small number of children. If I can reproduce in the debugger I can get much more details. |
Sounds relevant to #539 |
I'm able to reproduce it in a debug-launched IDE: Worse still is that while inspecting the state of the variables in the debugging IDE, the debugging IDE itself hangs. The hung debugging IDE is in this state:
All this points the finger at TextLayout and its callees. I'll try to determine the state of the TextLayout so it can reproduced directly, hopefully. |
Which character is inside 'chars'? You can try to print its numeric value |
Yes, that's what I'm trying to do, though I was trying to use a conditional breakpoint to do that, but my debugging IDE hangs really easily when I click on the variables view. I think it will be better if I import SWT as a project so I can edit it... |
I can reproduce the problem with this slightly modified (added bad characters to the text) SWT snippet:
It's still not clear why this has not be a long standing problem... |
Adding this isISOControl guard fixes the problem:
Of course it would be better that |
@merks : any idea how this character ends in the search results? Is this some file in your workspace that contains this character, or is the search somehow creates these characters (illegally splitting unicode strings etc)? |
Yes, I did track down where this comes from in Oomph's case, from its use of EMF's DiagnosticDecorator.enquote, which should be post processed with DiagnsoticDecorator.strip but wasn't, but this has been this way for the last 5 years and only just in the last weeks has turned into a problem. In any case, I fixed Oomph to remove these characters. In this case the Textlayout that hangs was used for ToolTip processing. The search hang happens directly from the owner draw of a search item and that was in my Mylyn workspace... |
This almost duplicates #414 (also STX) |
@merks Eclipse SDK After this is shown up, i move on to another snippet and all works fine for me. |
@merks if you windows hangs on a single OS call you should report to Microsoft |
Maybe it's something caused by a recent Windows 10 update and will go away with an update to Windows 11. I've had this happen again several times since then with the Console view and with the Search view. I doubt reporting a problem to MS will be any more successful than reporting a problem and providing a solution #680 (comment) is here. They too will want something to reproduce the problem and that investment of time I can better invest more effectively on other things and we can all hope no one else sees such a problem. |
Describe the bug
I've repeatedly had hangs in the last few days, always while expanding some tree item. In this case a search tree item and it's permanently stuck here:
This is based on the m2 state of release train repository.
To Reproduce
I don't know.
Environment:
Additional OS info (e.g. OS version, Linux Desktop, etc)
JRE/JDK version
Java 17.
Version since
The m2 version of 4.28
Workaround (or) Additional context
I must kill the process and this will have been the 20th time I've done that in the last days.
The text was updated successfully, but these errors were encountered: