Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The internal browser is outdated #840

Closed
wimjongman opened this issue Oct 18, 2023 · 13 comments · Fixed by #1637
Closed

The internal browser is outdated #840

wimjongman opened this issue Oct 18, 2023 · 13 comments · Fixed by #1637

Comments

@wimjongman
Copy link

We cannot receive youtube anymore in the internal browser.

image

@akurtakov
Copy link
Member

Which operating system is this? Based on that it could be determined which one the underlying web engine is.
This is SWT issue so I move it there.

@akurtakov akurtakov transferred this issue from eclipse-platform/eclipse.platform.ui Oct 18, 2023
@vogella
Copy link
Contributor

vogella commented Oct 18, 2023

Most likely Windows. I have seem that too. I think SWT still uses IE on Windows.

@Phillipus
Copy link
Contributor

Assuming you're on Windows you could use Edge by adding this to eclipse.ini (and make sure Edge Runtime is installed):

-Dorg.eclipse.swt.browser.DefaultType=edge

But you'll find other issues using Edge:

https://github.com/eclipse-platform/eclipse.platform.swt/issues?q=edge+browser

@vogella
Copy link
Contributor

vogella commented Oct 18, 2023

@Phillipus can Eclipse use the internal Edge browser? I though that was not possible and requires an extra installation of Edge.

@Phillipus
Copy link
Contributor

Phillipus commented Oct 18, 2023

@Phillipus can Eclipse use the internal Edge browser? I though that was not possible and requires an extra installation of Edge.

I think Windows 11 ships with Edge Runtime. For Windows 10 see:

https://www.eclipse.org/swt/faq.php#howuseedge

@vogella
Copy link
Contributor

vogella commented Oct 18, 2023

@Phillipus awesome to hear that Windows 11 provides Edge. I think if SWT runs on Windows 11 we should in this case default to Edge instead of the unmaintained IE API

@Phillipus
Copy link
Contributor

Phillipus commented Oct 18, 2023

@Phillipus awesome to hear that Windows 11 provides Edge. I think if SWT runs on Windows 11 we should in this case default to Edge instead of the unmaintained IE API

There are issues with Edge to use it as default. Welcome screens not rendering CSS and images, and hover tooltips are the most notable issues reported. See #213

@HeikoKlare
Copy link
Contributor

The premature state of the Edge browser can also be seen in #672. I tried to enable the browser tests for Edge with that PR, but did not yet get it running properly. Still you can see in the PR how many tests have to be disabled for the Edge browser because either there is no API for the functionality or because it has not been implemented in SWT yet.

@eliasbalasis
Copy link

I understand the problem and even though there is still a temporary workaround using Dorg.eclipse.swt.browser.DefaultType=edge at eclipse-lsp4e/lsp4e#820 it is not permanent and may start breaking going forward.

Unfortunately, I don't have enough familiarity to contribute, but I do need to stress the importance.

@Phillipus
Copy link
Contributor

Even if Edge-related bugs are fixed a major issue to address is #213, and see this comment.

@eliasbalasis
Copy link

It starts sounding like the tip of the iceberg.

@eliasbalasis
Copy link

In relation to eclipse-lsp4e/lsp4e#820

On Eclipse 2023-09 with m2e 2.4.0
-Dorg.eclipse.swt.browser.DefaultType=edge is not needed anymore on Windows OS.

@wimjongman
Copy link
Author

wimjongman commented Dec 10, 2024

Thank you all. I will try out if the web view templates in PDE still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants