Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymlinkTest fails on Windows after converting to JUnit 4 #783

Closed
iloveeclipse opened this issue Oct 27, 2023 · 1 comment · Fixed by #785
Closed

SymlinkTest fails on Windows after converting to JUnit 4 #783

iloveeclipse opened this issue Oct 27, 2023 · 1 comment · Fixed by #785
Assignees
@HeikoKlare
Labels
bug Something isn't working regression Regression defect

Comments

@iloveeclipse
Copy link
Member

See https://download.eclipse.org/eclipse/downloads/drops4/I20231027-0140/testresults/html/org.eclipse.core.tests.resources_ep430I-unit-win32-java17_win32.win32.x86_64_17.html

Most likely regression from 826efd6.

@HeikoKlare : please check.

Multiple Failures (2 failures) org.junit.TestCouldNotBeSkippedException: Test could not be skipped due to other failures java.lang.NullPointerException: Cannot invoke "org.eclipse.core.filesystem.IFileStore.delete(int, org.eclipse.core.runtime.IProgressMonitor)" because "this.localFileBaseStore" is null

org.opentest4j.MultipleFailuresError: Multiple Failures (2 failures)
org.junit.TestCouldNotBeSkippedException: Test could not be skipped due to other failures
java.lang.NullPointerException: Cannot invoke "org.eclipse.core.filesystem.IFileStore.delete(int, org.eclipse.core.runtime.IProgressMonitor)" because "this.localFileBaseStore" is null
Suppressed: org.junit.TestCouldNotBeSkippedException: Test could not be skipped due to other failures
Caused by: org.junit.AssumptionViolatedException: Can't create symbolic links in this platform: win32
at org.junit.Assume.assumeTrue(Assume.java:68)
at org.eclipse.core.tests.filesystem.SymlinkTest.setUp(SymlinkTest.java:106)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
Suppressed: java.lang.NullPointerException: Cannot invoke "org.eclipse.core.filesystem.IFileStore.delete(int, org.eclipse.core.runtime.IProgressMonitor)" because "this.localFileBaseStore" is null
at org.eclipse.core.tests.filesystem.FileSystemTest.tearDown(FileSystemTest.java:101)
at org.eclipse.core.tests.filesystem.SymlinkTest.tearDown(SymlinkTest.java:116)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
@iloveeclipse iloveeclipse added bug Something isn't working regression Regression defect labels Oct 27, 2023
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Oct 27, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
2b45b68 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
@HeikoKlare HeikoKlare mentioned this issue Oct 27, 2023
Merged
@HeikoKlare
Copy link
Contributor

Yes, it's a regression from #755. I propose to properly restructure the FileSystemTests to avoid the complex and error-prone setup/teardown inheritance coming from the original JUnit 3 implementation, which is not necessary with JUnit 4/5 anymore. I started PR #785 for that.

HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Oct 27, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
38f6d02 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Oct 27, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
22f1e7e 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Oct 27, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
297fa64 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Oct 28, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
cefe594 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
@HeikoKlare HeikoKlare mentioned this issue Nov 2, 2023
Closed
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 2, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
b20088c 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 3, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
ee8abb4 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 3, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
958ff81 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 3, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
33574c0 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 4, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
5976c03 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 6, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
c6bab79 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Nov 6, 2023
@HeikoKlare
Simplify and correct FileSystemTests eclipse-platform#783
dec3328 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
fedejeanne pushed a commit that referenced this issue Nov 6, 2023
@HeikoKlare @fedejeanne
Simplify and correct FileSystemTests #783
99f33c3 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (#783)

Fixes #783.
Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this issue Feb 12, 2024
@HeikoKlare @Michael5601
Simplify and correct FileSystemTests eclipse-platform#783
e24b0f1 
Several test classes extend the FileSystemTest. This class only provides
some utility functions and always creates a local and an in-memory file
store, even if the actual test does not need it.

This change simplifies the test classes by removing the FileSystemTest
super class. The necessary utilities are moved to a utility class. The
file store creation logic is moved to an according JUnit test rule that
can be instantiated for a local or in-memory file store and keeps track
of setup and teardown.
This also fixes a bug in interwoven, inherited setup and teardown
functions (eclipse-platform#783)

Fixes eclipse-platform#783.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeikoKlare HeikoKlare

Labels
bug Something isn't working regression Regression defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify and correct FileSystemTests #783 HeikoKlare/eclipse.platform
2 participants
@HeikoKlare @iloveeclipse