-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Oomph-Setup] Add eclipse.platform configuration setup #1582
[Oomph-Setup] Add eclipse.platform configuration setup #1582
Conversation
Probably the new project will have a warning about not having an explicit coding... Note that it's essential that the configuration be referenced from something that is in the setup Index. Otherwise it will not work very well, i.e., the badge will not be generated: https://ci.eclipse.org/oomph/job/setup-archiver/ Also what's in the archive is unzipped to this location: https://download.eclipse.org/justj/?file=oomph/www/setups/ And that's what makes it possible to show the configuration's documentation on the page: We can't pull it directly from GitHub because of cross-site scripting restrictions. And finally, if the platform repository is going to have its own configuration, the project setup for it should probably be factored out and also put in that git repository like is already the case for some of the other platform projects: There should then be an Eclipse Ini task with a redirection so one can modify/use/test the setup in the repository being set up. This would also be the good place from which to reference the configuration. |
1151079
to
35dd38f
Compare
Additionally add a styled and drag&drop-able Oomph Configuration button. Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
35dd38f
to
ca6a46c
Compare
Good point, I just added the corresponding setting.
Thank you for the reminder and the elaboration, that was very helpful! Added the reference via
That's something I also wanted to discuss, but want to leave it for later. First I would like each active repo to have it's own configuration and 'Oomph-setup button' in order to make it visible for contributors. With that, this should be ready for submission. The verification build does not test this at all. |
The README looks as expected: And the website it opens looks also fine: |
Additionally add a styled and drag&drop-able Oomph Configuration button.
Part of eclipse-platform/eclipse.platform.releng.aggregator#2430