Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oomph-Setup] Add eclipse.platform configuration setup #1582

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

HannesWell
Copy link
Member

Additionally add a styled and drag&drop-able Oomph Configuration button.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 34m 8s ⏱️ + 7m 9s
 4 170 tests ±0   4 148 ✅ +1   22 💤 ±0  0 ❌  - 1 
13 107 runs  ±0  12 943 ✅ +1  164 💤 ±0  0 ❌  - 1 

Results for commit 35dd38f. ± Comparison against base commit 9a8e0e6.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Oct 7, 2024

Probably the new project will have a warning about not having an explicit coding...

Note that it's essential that the configuration be referenced from something that is in the setup Index. Otherwise it will not work very well, i.e., the badge will not be generated:

https://ci.eclipse.org/oomph/job/setup-archiver/

Also what's in the archive is unzipped to this location:

https://download.eclipse.org/justj/?file=oomph/www/setups/

And that's what makes it possible to show the configuration's documentation on the page:

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-platform/eclipse.platform/master/releng/org.eclipse.platform.setup/EclipsePlatformConfiguration.setup&show=true

We can't pull it directly from GitHub because of cross-site scripting restrictions.

And finally, if the platform repository is going to have its own configuration, the project setup for it should probably be factored out and also put in that git repository like is already the case for some of the other platform projects:

image

There should then be an Eclipse Ini task with a redirection so one can modify/use/test the setup in the repository being set up. This would also be the good place from which to reference the configuration.

@HannesWell HannesWell force-pushed the oomph-configuration branch from 1151079 to 35dd38f Compare October 7, 2024 18:07
Additionally add a styled and drag&drop-able Oomph Configuration button.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
@HannesWell
Copy link
Member Author

Probably the new project will have a warning about not having an explicit coding...

Good point, I just added the corresponding setting.

Note that it's essential that the configuration be referenced from something that is in the setup Index. Otherwise it will not work very well, i.e., the badge will not be generated:

Thank you for the reminder and the elaboration, that was very helpful!

Added the reference via

And finally, if the platform repository is going to have its own configuration, the project setup for it should probably be factored out and also put in that git repository like is already the case for some of the other platform projects:

That's something I also wanted to discuss, but want to leave it for later. First I would like each active repo to have it's own configuration and 'Oomph-setup button' in order to make it visible for contributors.
In a second step I can then move around the setups to be managed in their repository.
In eclipse-platform/eclipse.platform.releng.aggregator#2437 I have now referenced this configuration using a complete URL.

With that, this should be ready for submission. The verification build does not test this at all.

@HannesWell HannesWell merged commit 6887f61 into eclipse-platform:master Oct 7, 2024
8 of 12 checks passed
@HannesWell HannesWell deleted the oomph-configuration branch October 7, 2024 21:15
@HannesWell
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants