Issues integrating Eclipse Store as an Helidon 4 extension

[hrstoyanov]

Hello,
I am trying to integrate Eclipse Store into Helidon 4, similarly to how Microstream 8 was integrated in Helidon 4.

However, I face some issues with the eclipse store codebase:

1. If I use the official release 1.0.0, I noticed that it lacks the cache module, which exists in the Microstream 8 and is, therefore, used in the Helidon 4 extension?

2. if I try 1.1.0-SNAPSHOT (which is what the current main branch uses), the cache module was added back, but all module-info.java were stripped away - why?

@fh-ms @zdenek-jonas

[hrstoyanov]

Also, what happened to BinaryHandlersJDK17::registerJDK17TypeHandlers - was it removed?

[fh-ms]

Binary handlers are part of the serializer project.

https://github.com/eclipse-serializer/serializer/blob/main/persistence/binary-jdk17/src/main/java/org/eclipse/serializer/persistence/binary/jdk17/types/BinaryHandlersJDK17.java

https://docs.eclipsestore.io/manual/storage/addendum/specialized-type-handlers.html#jdk17

[fh-ms]

Cache will come with 1.1, in about 2 weeks from now.

[hrstoyanov]

Ok. Let me add JDK17 enhancement then.

At this point the new Helidon integration compiles and finishes the tests- can you please review the code here:
https://github.com/hrstoyanov/helidon/tree/eclipse-store

I will be able to create a helidon merge request once ES 1.10 is official.

[fh-ms]

Thx, will do!

[hrstoyanov]

@fh-ms I added back the JDK17 enhancement.

Question:
The eclipse-store version used for the Helidon extension is defined here:
https://github.com/hrstoyanov/helidon/blob/eclipse-store/dependencies/pom.xml#L123

It is referenced here for several artifacts, but uses the same version variable defined above for persistence-binary-jdk17 (as this artfact is not transitively included and needs to be included explicitly?):
https://github.com/hrstoyanov/helidon/blob/eclipse-store/dependencies/pom.xml#L813

eclipse-store is technically a different project from eclipse-serializer, so maybe we should specify its version in a separate variable if the version deviate in the future?

<version.lib.eclipseserializer>1.1.0-SNAPSHOT</version.lib.eclipseserializer>

[fh-ms]

Yes, the jdk-17 dependency is optional and has to be included explicitly.

We use a variable for the Serializer version in EclipseStore as well, whereas the version will probably never deviate.

[hrstoyanov]

Ok, I added a version variable on the request to Helidon, pls verify it