Keybinding not mapped correctly depending on Keyboard Layout

[jfaltermeier]

Bug Description:

Keybindings including AltGr do not work (on German keyboard layout at least)

Steps to Reproduce:

1. Use German keyboard layout
2. Add a keybinding for e.g. "Ctrl+["
3. Keybinding is not working. In the UI it shows as "Ctrl+ü", which actually works. (I think ü is [ on US layout)
4. When I click to edit the binding again, it shows "Ctrl+[" though.

Additional Information

I'm not sure if there is a general issue with detecting Alt Gr/Figuring out the required keys for each layout.
However I think we shouldn't map to wrong keybindings at least.

• Operating System: Ubuntu
• Theia Version: master

[rschnekenbu]

I don't know if this is related, but I get a lot of errors at startup about key bindings: [1175888:0709/134222.061193:ERROR:accelerator_util.cc(23)] The accelerator string can only contain ASCII characters, invalid string: "Ctrl+Shift+à"
I can reproduce the issue with a French keyboard too, with the keybindings containing ².

[tsmaeder]

Any keybinding to "ä" in a swiss-german keyboard will provoke the above message, as well. If we can't support those accelerators, we should at least catch them from going to the electron code.
Btw: VS Code can handle accelerators like "Ctrl+§" no Problem, so it must be possible somehow.

[tYYGH]

Same issue for me. France has 2 official layouts: AZERTY and BÉPO. I’m using the BÉPO layout, on Archlinux.
With it:

• Ctrl+z (i.e. left Ctrl + ^ physical key) does an outdent instead of undo (they indeed share the same shortcut), but even removing all Ctrl+z bindings except the one for undo does not let me use the undo feature.
• Ctrl+w (i.e. left Ctrl + $ physical key) does an indent instead of closing the tab; same problem as undo.

It’s my first day using Theia, and so far I did not use other key-bindings (except Ctrl+Shift+P —physical key E—, which works). So I tried to open the keybinding (Ctrl+Alt+,, i.e. left Ctrl and Alt + G physical key) and it works. Maybe those that work are those associated to an alphabetical physical keys…

For your information, I explicitly specify “left” above, because on French keyboards, left and right Alt keys have a totally different role, and are never interchangeable.