Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused tab is not the expected one when closing the last in the tabbar #13886

Closed
rschnekenbu opened this issue Jul 4, 2024 · 1 comment · Fixed by #13912
Closed

Focused tab is not the expected one when closing the last in the tabbar #13886

rschnekenbu opened this issue Jul 4, 2024 · 1 comment · Fixed by #13912
Assignees
Labels
ui/ux issues related to user interface / user experience
Milestone

Comments

@rschnekenbu
Copy link
Contributor

When closing editors or view in Theia, the last focused tab is selected in the bar.
When there is no 'previous' widget found, the selected tab is the next tab to the right, except when the widget is the last one.
In this case, the first widget is selected, rather than the one to the left of the closed tab.

Example:

Tabbar_Focus.mp4
@rschnekenbu rschnekenbu added the ui/ux issues related to user interface / user experience label Jul 4, 2024
@rschnekenbu
Copy link
Contributor Author

nextTabIndexInTabBar(current: TabBar<Widget> | undefined = this.currentTabBar): number {

The case index === current.titles.length - 1 should probably return index-1. Currently, it is not part of the existing tests, so it returns 0.

@rschnekenbu rschnekenbu self-assigned this Jul 4, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jul 11, 2024
fixes eclipse-theia#13886

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jul 11, 2024
fixes eclipse-theia#13886

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jul 18, 2024
fixes eclipse-theia#13886

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@sgraband sgraband added this to the 1.52.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants