Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] downgrade jsdom to 22.1.0 #13943

Closed
rschnekenbu opened this issue Jul 22, 2024 · 2 comments · Fixed by #13944
Closed

[chore] downgrade jsdom to 22.1.0 #13943

rschnekenbu opened this issue Jul 22, 2024 · 2 comments · Fixed by #13944
Assignees
@rschnekenbu
Labels
dependencies pull requests that update a dependency file
Milestone
1.52.0

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Jul 22, 2024 •
edited
Loading

Current version of jsdom pushed with #13903 requires node 18 as a minimum, where Theia only requires node 16 (see #13903 (comment)).
The dependency shall be downgraded to be 22.1.0, to avoid test failures.
@rschnekenbu rschnekenbu added the dependencies pull requests that update a dependency file label Jul 22, 2024
@rschnekenbu rschnekenbu self-assigned this Jul 22, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jul 22, 2024
@rschnekenbu
[chore] downgrade jsdom to 22.1.0
e3e08f9 
fixes eclipse-theia#13943
@rschnekenbu rschnekenbu mentioned this issue Jul 22, 2024
Merged
1 task
@msujew
Copy link
Member

msujew commented Jul 22, 2024

Given that there are quite a few of our dependencies that would require node >=18 in their latest versions, shouldn't we just deprecate Node 16 support by now? It's been out of LTS for a few months now and nobody should continue using it anyway.

I think this would be a better solution to this than downgrading jsdom and therefore pulling a vulnerable extension in our dev environments.

@rschnekenbu
Copy link
Contributor Author

That'a a good point. Should this decision be part of the next developer meeting?

rschnekenbu added a commit that referenced this issue Jul 25, 2024
@rschnekenbu
[chore] downgrade jsdom to 22.1.0 (#13944)
fe4cd14 
fixes #13943
@rschnekenbu rschnekenbu mentioned this issue Jul 25, 2024
Closed
@sgraband sgraband added this to the 1.52.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
dependencies pull requests that update a dependency file
Projects
None yet
Milestone
1.52.0
Development

Successfully merging a pull request may close this issue.

[chore] downgrade jsdom to 22.1.0 eclipsesource/theia
3 participants
@rschnekenbu @msujew @sgraband