Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Diff] Images should open in preview #9079

Closed
ghuntley opened this issue Feb 17, 2021 · 5 comments · Fixed by #13916
Closed

[Diff] Images should open in preview #9079

ghuntley opened this issue Feb 17, 2021 · 5 comments · Fixed by #13916
Labels
help wanted issues meant to be picked up, require help scm issues related to the source control manager
Milestone
1.53.0

Comments

@ghuntley
Copy link

ghuntley commented Feb 17, 2021 •
edited
Loading

The default open handler of binary images (gif, png, jpg, jpeg) in the diff pane should display images as a preview when double clicking them.

Feature Description:

image
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help scm issues related to the source control manager labels Feb 17, 2021
@vince-fugnitto
Copy link
Member

@ghuntley thank you for reporting the issue, is this something you're interested in fixing? (we can guide you if you'd like).

@ghuntley
Copy link
Author

I absolutely am and would love if you could introduce me to the correct parts of the codebase.

@vince-fugnitto
Copy link
Member

I absolutely am and would love if you could introduce me to the correct parts of the codebase.

I'll do some investigation and see if I can try and find some information for anyone interested in fixing the issue. We have some open PRs that affect the SCM which we may want to wait for before attempting to fix the problem.

@pisv
Copy link
Contributor

pisv commented Jul 1, 2024

Just a note that I'm currently working on this feature. It happened to be quite complicated, a number of things across Theia needed to be fixed to make it work, but I'm making steady progress and hope to share a PR with you soon.

Basically, the CustomEditorOpener will be able to open a diff-uri in a side-by-side editor, so it is going to support more than just images. Here's a preview:

Screenshot

@pisv pisv mentioned this issue Jul 1, 2024
Closed
pisv added a commit to pisv/theia that referenced this issue Jul 9, 2024
@pisv
custom editor: open a diff-uri in a side-by-side editor
aa3922d 
`CustomEditorOpener` is now able to open a diff-uri in a side-by-side editor,
which contains the corresponding `CustomEditor`s.

Fixes eclipse-theia#9079
pisv added a commit to pisv/theia that referenced this issue Jul 9, 2024
@pisv
custom editor: open a diff-uri in a side-by-side editor
6e48b04 
`CustomEditorOpener` is now able to open a diff-uri in a side-by-side editor,
which contains the corresponding `CustomEditor`s.

Fixes eclipse-theia#9079
pisv added a commit to pisv/theia that referenced this issue Jul 10, 2024
@pisv
custom editor: open a diff-uri in a side-by-side editor
1943d99 
`CustomEditorOpener` is now able to open a diff-uri in a side-by-side editor,
which contains the corresponding `CustomEditor`s.

Fixes eclipse-theia#9079
@pisv pisv mentioned this issue Jul 11, 2024
Merged
1 task
@pisv
Copy link
Contributor

pisv commented Jul 11, 2024

I have submitted PR #13916 that hopefully will fix this issue.

pisv added a commit to pisv/theia that referenced this issue Jul 11, 2024
@pisv
custom editor: open a diff-uri in a side-by-side editor
88ac8e8 
`CustomEditorOpener` is now able to open a diff-uri in a side-by-side editor,
which contains the corresponding `CustomEditor`s.

Fixes eclipse-theia#9079
pisv added a commit to pisv/theia that referenced this issue Aug 7, 2024
@pisv
custom editor: open a diff-uri in a side-by-side editor
90e6932 
`CustomEditorOpener` is now able to open a diff-uri in a side-by-side editor,
which contains the corresponding `CustomEditor`s.

Fixes eclipse-theia#9079
@msujew msujew closed this as completed in 6f36201 Aug 21, 2024
@jfaltermeier jfaltermeier added this to the 1.53.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted issues meant to be picked up, require help scm issues related to the source control manager
Projects
None yet
Milestone
1.53.0
Development

Successfully merging a pull request may close this issue.

Allow opening changes for files associated with custom editors pisv/theia
4 participants
@ghuntley @jfaltermeier @pisv @vince-fugnitto