Add Future eventually method with a supplier of future and deprecate the method with a function #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, Future<T>>, this was developed for codegen which did not support Supplier. The Future object is not code generated anymore since Vert.x 4, we can therefore use Supplier which is more suitable. Add Future#eventually(Supplier<Future<T>>) and deprecate Future#eventually(Function<Void, Future<T>>) for removal in Vert.x 5. The method is defined as a default method of Future and therefore all Future implementations will have it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vertx
Future#eventuallymethod takes as parameter aFunction<Void, Future<T>>, this was developed for codegen which did not supportSupplier. TheFutureobject is not code generated anymore since Vert.x 4, we can therefore useSupplierwhich is more suitable.Add
Future#eventually(Supplier<Future<T>>)and deprecateFuture#eventually(Function<Void, Future<T>>)for removal in Vert.x 5.The method is defined as a default method of Future and therefore all Future implementations will have it automatically.